small fixes (#1889)

* pid percent rounding

* mpc loss fix

* mpc loss fix

* trvzb valve maintenance interval

Author: wtom

custom_components/better_thermostat/model_fixes/TRVZB.py

@@ -11,7 +11,7 @@
 
 _LOGGER = logging.getLogger(__name__)
 
-VALVE_MAINTENANCE_INTERVAL_HOURS = 24
+VALVE_MAINTENANCE_INTERVAL_HOURS = 84
 
 # Some users report that the TRVZB motor can occasionally lose its calibration and
 # fail to fully close the valve when commanded to very small openings.

custom_components/better_thermostat/utils/calibration/mpc.py

@@ -80,9 +80,6 @@ class MpcParams:
     perf_curve_bin_pct: float = 2.0
 
 
-
-
-
 @dataclass
 class MpcInput:
     """Input parameters for MPC calibration calculation."""
@@ -380,7 +377,6 @@ def build_mpc_key(bt, entity_id: str) -> str:
     return f"{uid}:{entity_id}:{bucket}"
 
 
-
 def _detect_regime_change(recent_errors: list[float]) -> bool:
     """Detect systematic bias in prediction errors using Student's t-test.
 
@@ -1099,7 +1095,7 @@ def _compute_predictive_percent(
                 common_ok
                 and learn_signal
                 and u_last <= min_open
-                and observed_rate < -0.01
+                and observed_rate < 0.0  # Allow learning even on slow cooling
             ):
                 loss_candidate = max(0.0, -observed_rate)
 
@@ -1206,7 +1202,6 @@ def _compute_predictive_percent(
                             gain_method = "insufficient_heat_boost"
                             adapt_debug["gain_boosted_insuff"] = True
 
-
             # --- LOSS learning (warming with low valve): ---
             # If we are below u0 but the room is warming, loss is overestimated.
             # This handles the case where residual_u0_ss fails because rate is too high (warming).
@@ -1215,7 +1210,7 @@ def _compute_predictive_percent(
                 and learn_signal
                 and (not updated_loss)
                 and u_last < (u0_frac_est - 0.05)
-                and observed_rate > 0.01
+                and observed_rate > 0.0
             ):
                 # We are warming, so gain*u > loss.
                 # Since u is small, loss must be very small.

custom_components/better_thermostat/utils/calibration/pid.py

@@ -322,6 +322,8 @@ def compute_pid(
 
     # Clamp final result
     percent = max(0.0, min(100.0, percent))
+    # Round to nearest integer to avoid micro-updates that trigger TRV logic
+    percent = int(round(percent))
 
     # Update last_percent
     st.last_percent = percent