Skip to content

Commit 00ae47e

Browse files
davidkrmelaenumag
authored andcommitted
Fix $lifeTime condition in Cache::doSave (#18)
1 parent 4c41b54 commit 00ae47e

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/Cache.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ protected function doSave($id, $data, $lifeTime = 0)
108108
protected function doSaveDependingOnFiles($id, $data, array $files, $lifeTime = 0)
109109
{
110110
$dp = [NCache::TAGS => ['doctrine'], NCache::FILES => $files];
111-
if ($lifeTime !== 0) {
111+
if ($lifeTime > 0) {
112112
$dp[NCache::EXPIRE] = time() + $lifeTime;
113113
}
114114

tests/KdybyTests/DoctrineCache/CacheTest.phpt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,18 @@ class CacheTest extends \Tester\TestCase
4242
Assert::false($cache->fetch('nonexistent-key'));
4343
}
4444

45+
public function testZeroAndNullLifetime()
46+
{
47+
$storage = new MemoryStorage();
48+
$cache = new NetteCacheAdapter($storage, 'ns');
49+
50+
$cache->save('foo1', 'data', 0);
51+
$cache->save('foo2', 'data', NULL);
52+
53+
Assert::true($cache->contains('foo1'));
54+
Assert::true($cache->contains('foo2'));
55+
}
56+
4557
}
4658

4759
(new CacheTest())->run();

0 commit comments

Comments
 (0)