fix(sherweb): stop migration tasks from running after extension disable

Two defects allowed Invoke-SherwebMigration scheduled tasks to keep
firing daily (sending alerts and performing real Sherweb purchases and
Pax8 subscription cancellations) after the Sherweb migration was
disabled:

- Invoke-SherwebMigration had no enabled-guard: it read the Sherweb
  extension config but never checked Enabled before acting. It now
  returns immediately unless the Sherweb config exists and Enabled is
  true, which neutralizes any stale scheduled task.

- Register-CIPPExtensionScheduledTasks created migration tasks in the
  enable branch, but the disable cleanup only filtered
  Push-CippExtensionData tasks, so migration tasks were never removed.
  Migration tasks are now queried at function scope, removed when the
  Sherweb extension is disabled, and removed when a tenant is no longer
  Sherweb-mapped.

Author: Zacgoose

Modules/CippExtensions/Public/Extension Functions/Register-CippExtensionScheduledTasks.ps1

@@ -14,6 +14,7 @@ function Register-CIPPExtensionScheduledTasks {
     $ScheduledTasksTable = Get-CIPPTable -TableName ScheduledTasks
     $ScheduledTasks = Get-CIPPAzDataTableEntity @ScheduledTasksTable -Filter 'Hidden eq true' | Where-Object { $_.Command -match 'Sync-CippExtensionData' }
     $PushTasks = Get-CIPPAzDataTableEntity @ScheduledTasksTable -Filter 'Hidden eq true' | Where-Object { $_.Command -match 'Push-CippExtensionData' }
+    $SherwebMigTasks = Get-CIPPAzDataTableEntity @ScheduledTasksTable -Filter 'Hidden eq true' | Where-Object { $_.Command -match 'Invoke-SherwebMigration' }
     $Tenants = Get-Tenants -IncludeErrors
 
     # Remove all legacy Sync-CippExtensionData tasks (now deprecated - extensions use CippReportingDB)
@@ -32,7 +33,6 @@ function Register-CIPPExtensionScheduledTasks {
             if ($Extension -eq 'Sherweb') {
                 # Sherweb migration tasks - schedule per mapped tenant
                 $SherwebMappings = Get-CIPPAzDataTableEntity @MappingsTable -Filter "PartitionKey eq 'SherwebMapping'"
-                $SherwebMigTasks = Get-CIPPAzDataTableEntity @ScheduledTasksTable -Filter 'Hidden eq true' | Where-Object { $_.Command -match 'Invoke-SherwebMigration' }
                 foreach ($Mapping in $SherwebMappings) {
                     $Tenant = $Tenants | Where-Object { $_.customerId -eq $Mapping.RowKey }
                     if (-not $Tenant) { continue }
@@ -145,6 +145,14 @@ function Register-CIPPExtensionScheduledTasks {
                 $Entity = $_ | Select-Object -Property PartitionKey, RowKey
                 Remove-AzDataTableEntity -Force @ScheduledTasksTable -Entity $Entity
             }
+            if ($Extension -eq 'Sherweb') {
+                $SherwebMigTasks | ForEach-Object {
+                    Write-Information "Extension Disabled: Cleaning up scheduled task $($_.Name) for tenant $($_.Tenant)"
+                    $Entity = $_ | Select-Object -Property PartitionKey, RowKey
+                    Remove-AzDataTableEntity -Force @ScheduledTasksTable -Entity $Entity
+                }
+                $SherwebMigTasks = @() # Clear the list since we removed them all
+            }
         }
     }
     $MappedTenants = $MappedTenants | Sort-Object -Unique
@@ -163,4 +171,11 @@ function Register-CIPPExtensionScheduledTasks {
             Remove-AzDataTableEntity -Force @ScheduledTasksTable -Entity $Entity
         }
     }
+    foreach ($Task in $SherwebMigTasks) {
+        if ($Task.Tenant -notin $MappedTenants) {
+            Write-Information "Tenant Removed: Cleaning up scheduled task $($Task.Name) for tenant $($Task.TenantFilter)"
+            $Entity = $Task | Select-Object -Property PartitionKey, RowKey
+            Remove-AzDataTableEntity -Force @ScheduledTasksTable -Entity $Entity
+        }
+    }
 }

Modules/CippExtensions/Public/Sherweb/Invoke-SherwebMigration.ps1

@@ -8,6 +8,11 @@ function Invoke-SherwebMigration {
     $ExtensionConfig = (Get-CIPPAzDataTableEntity @Table).config | ConvertFrom-Json
     $Config = $ExtensionConfig.Sherweb
 
+    if ($Config.Enabled -ne $true) {
+        Write-Information "Sherweb extension is disabled, skipping migration check for $TenantFilter"
+        return
+    }
+
     # Get licenses within the transfer window (renewing within 7 days)
     $Licenses = Get-CIPPLicenseOverview -TenantFilter $TenantFilter | Where-Object {
         $null -ne $_.TermInfo -and ($_.TermInfo | Where-Object { $_.DaysUntilRenew -le 7 -and $_.DaysUntilRenew -ge 0 })