fix(auth): skip SSO nag before setup is complete

JohnDuprey · JohnDuprey · commit fe1be54d4ea6 · 2026-07-21T17:06:03.000-04:00
Suppress the SSO migration prompt until the SAM app is configured, matching the same setup-completion check used by GetCippAlerts.
diff --git a/Modules/CIPPCore/Public/Authentication/Test-CIPPAccess.ps1 b/Modules/CIPPCore/Public/Authentication/Test-CIPPAccess.ps1
@@ -244,7 +244,11 @@ function Test-CIPPAccess {
                 }
             }
 
-            if ($env:CIPPNG -ne 'true' -and $HasAnyPermission) {
+            # SSO migration requires a working SAM app — suppress the nag until initial
+            # setup is complete (same check GetCippAlerts uses for its setup alert)
+            $SetupCompleted = $env:ApplicationID -and $env:ApplicationID -ne 'LongApplicationID'
+
+            if ($env:CIPPNG -ne 'true' -and $HasAnyPermission -and $SetupCompleted) {
                 try {
                     $SSOTable = Get-CIPPTable -tablename 'SSOMigration'
                     $SSOMigration = Get-CIPPAzDataTableEntity @SSOTable -Filter "PartitionKey eq 'SSO' and RowKey eq 'MigrationConfig'" -ErrorAction SilentlyContinue

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,11 @@ function Test-CIPPAccess {`
`244`	`244`	`}`
`245`	`245`	`}`
`246`	`246`
`247`		`- if ($env:CIPPNG -ne 'true' -and $HasAnyPermission) {`
	`247`	`+ # SSO migration requires a working SAM app — suppress the nag until initial`
	`248`	`+ # setup is complete (same check GetCippAlerts uses for its setup alert)`
	`249`	`+ $SetupCompleted = $env:ApplicationID -and $env:ApplicationID -ne 'LongApplicationID'`
	`250`	`+`
	`251`	`+ if ($env:CIPPNG -ne 'true' -and $HasAnyPermission -and $SetupCompleted) {`
`248`	`252`	`try {`
`249`	`253`	`$SSOTable = Get-CIPPTable -tablename 'SSOMigration'`
`250`	`254`	`$SSOMigration = Get-CIPPAzDataTableEntity @SSOTable -Filter "PartitionKey eq 'SSO' and RowKey eq 'MigrationConfig'" -ErrorAction SilentlyContinue`