fix lint nits

Author: Ken Kundert

examples/accumulation/settings.py

@@ -1,6 +1,5 @@
 from inform import Error, full_stop, os_error
 import nestedtext as nt
-from pathlib import Path
 
 schema = dict(
     name = str,

examples/accumulation/test_read_settings.py

@@ -1,5 +1,5 @@
 # imports {{{1
-from flatten_dict import flatten, unflatten
+from flatten_dict import flatten
 from functools import partial
 from inform import Error
 from parametrize_from_file import parametrize

examples/test_examples.py

@@ -1,9 +1,8 @@
 # encoding: utf8
 
 from pathlib import Path
-from shlib import Run, cd, cwd, to_path
+from shlib import Run, cd, to_path
 from textwrap import dedent
-import pytest
 import sys
 
 tests_dir = Path(__file__).parent

examples/validation/deploy_voluptuous.py

@@ -3,7 +3,7 @@
 import nestedtext as nt
 from voluptuous import Schema, Coerce, MultipleInvalid
 from voluptuous_errors import report_voluptuous_errors
-from inform import error, full_stop, terminate
+from inform import terminate
 from pprint import pprint
 
 schema = Schema({

nestedtext/nestedtext.pyi

@@ -147,7 +147,7 @@ def get_keys(
     keys: tuple[str | int, ...],
     keymap: dict[tuple[str | int, ...], Location],
     original: bool = ...,
-    strict: bool | string = ...,
+    strict: bool | str = ...,
     sep: str = ...,
 ) -> tuple[str | int, ...] | str:
     ...

proposed_tests/README.rst

@@ -219,6 +219,11 @@ types:
         string item
         unrecognized
 
+    As an example, if the implementation you are testing is limited to Minimal 
+    NestedText, you can filter out tests that use the more advance features of 
+    NestedText by simply ignoring those test cases that contain *inline dict*, 
+    *inline list* or *key item*.
+
 
 Caveats
 -------

proposed_tests/test_nt.py

@@ -1,12 +1,11 @@
 # IMPORTS {{{1
 from functools import partial
-from inform import cull, indent, render
+from inform import cull, render
 from parametrize_from_file import parametrize
 from pathlib import Path
-from voluptuous import Schema, Optional, Required, Any, Invalid
+from voluptuous import Schema, Required, Any
 from base64 import b64decode
 import nestedtext as nt
-import json
 
 # GLOBALS {{{1
 TEST_SUITE = Path('tests.json')
@@ -105,7 +104,6 @@ def test_nt(tmp_path, load_in, load_out, load_err, encoding, types, request):
     except UnicodeDecodeError as e:
         problematic = e.object[e.start:e.end]
         prefix = e.object[:e.start]
-        suffix = e.object[e.start:]
         lineno = prefix.count(b'\n')
         _, _, bol = prefix.rpartition(b'\n')
         eol, _, _ = e.object[e.start:].partition(b'\n')
@@ -134,11 +132,11 @@ def test_nt(tmp_path, load_in, load_out, load_err, encoding, types, request):
     # vary between implementations and with dump options.
     try:
         dumped = nt.dumps(result)
-    except nt.NestedTextError as e:
+    except nt.NestedTextError:
         checker.check(None, result, "dumping")
 
     try:
         result = nt.loads(dumped, top=any)
         checker.check(load_out, result, "re-loading")
-    except nt.NestedTextError as e:
+    except nt.NestedTextError:
         checker.check(None, result, "re-loading")

pyproject.toml

@@ -33,3 +33,17 @@ changelog = "https://github.com/KenKundert/nestedtext/blob/master/doc/releases.r
 [build-system]
 requires = ["flit_core >=2,<4"]
 build-backend = "flit_core.buildapi"
+
+[tool.pytest.ini_options]
+addopts = "--tb=short"
+
+[tool.ruff]
+exclude = [".tox", "doc"]
+
+[tool.ruff.lint]
+select = ["F"]
+ignore = []
+
+[tool.ruff.lint.per-file-ignores]
+"nestedtext/__init__.py" = ["F401"]
+"examples/parametrize_from_file/test_misc.py" = ["F401"]

tests/test_nestedtext.py

@@ -7,10 +7,9 @@
 from pathlib import Path
 from functools import wraps
 from io import StringIO
-from inform import Error, Info, render, indent, join, dedent
+from inform import Error, Info, join, dedent
 from quantiphy import Quantity
 import subprocess
-import json
 import os
 
 test_api = Path(__file__).parent / 'official_tests' / 'api'
@@ -1195,7 +1194,6 @@ def test_key_utilities():
 
     unknown_norm = ('user_names', 'Anastacia Pickett Cheek', 'unknown key')
     unknown_orig = ('user  Names', 'Anastacia Pickett__Cheek', 'unknown key')
-    unknown_index = ('scores', 3)
 
     def normalize_key(key, parent_keys):
         if parent_keys == ('user_names',):
@@ -1290,7 +1288,7 @@ def test_load_dialect():
 @parametrize(
     "top,expected", [(any,None), (dict,{}), (list,[]), (str,"")]
 )
-def test_empty_blank_lines(top, expected):
+def test_empty(top, expected):
     # just blank lines
     document = ""
 
@@ -1599,7 +1597,7 @@ def __nestedtext_converter__(self):
     converters = {ntInfo: False}
     with pytest.raises(nt.NestedTextError) as exc:
         dump(y, tmp_path, width=80, converters=converters)
-    assert str(exc.value) == f"info: unsupported type (ntInfo)."
+    assert str(exc.value) == "info: unsupported type (ntInfo)."
 
     # converting arrow object
     date = '1969-07-20'
@@ -2070,7 +2068,7 @@ def test_binary_round_trip(tmp_path):
 
     # dump nestedtext to a binary file
     with nt_path.open('wb') as f:
-        test_nt = nt.dump(orig_data, f)
+        nt.dump(orig_data, f)
 
     # read nestedtext from a binary file
     with nt_path.open('rb') as f:

tests/test_random.py

@@ -6,7 +6,7 @@
 # maps CR/LF and CR to LF, so the same is done to the input before comparing it
 # to the output.
 
-from hypothesis import assume, given, settings, strategies as st
+from hypothesis import given, settings, strategies as st
 import nestedtext as nt
 from random import randint
 import re
@@ -77,7 +77,7 @@ def test_dicts(data):
 
     # test normal dump
     result = nt.loads(nt.dumps(data), top=dict)
-    assert nt.loads(nt.dumps(data), top=dict) == expected
+    assert result == expected
 
     # test dump with inlines
     content = nt.dumps(data, width=999)