Hold on Window std::shared_ptr longer to avoid a crash at shudown

The crash is caused by acquiring content of the shared_ptr after it was released.
Added two shared_ptrs, one for ImGuiWMInit/Shudtown and the other for ImGuiBackendInit/Shutdown.
this way we are sure it's not used anymore by anyone.

Author: bassdr

include/fast/Fast3dGui.h

@@ -168,5 +168,8 @@ class Fast3dGui : public Ship::Gui {
     int16_t GetIntegerScaleFactor();
 
     std::unordered_map<std::string, Ship::GuiTextureMetadata> mGuiTextures; ///< Cached GPU texture registry.
+
+    std::shared_ptr<Ship::Window> mWindow;
+    std::shared_ptr<Ship::Window> mBackendWindow;
 };
 } // namespace Fast

src/fast/Fast3dGui.cpp

@@ -66,8 +66,7 @@ bool Fast3dGui::SupportsViewports() {
 }
 
 void Fast3dGui::HandleWindowEvents(Fast::WindowEvent event) {
-    auto window = Ship::Context::GetInstance()->GetWindow();
-    switch (window->GetWindowBackend()) {
+    switch (mWindow->GetWindowBackend()) {
         case WindowBackend::FAST3D_SDL_OPENGL:
         case WindowBackend::FAST3D_SDL_METAL:
             ImGui_ImplSDL2_ProcessEvent(static_cast<const SDL_Event*>(event.Sdl.Event));
@@ -87,10 +86,11 @@ void Fast3dGui::HandleWindowEvents(Fast::WindowEvent event) {
 }
 
 void Fast3dGui::ImGuiWMInit() {
-    auto window = Ship::Context::GetInstance()->GetWindow();
-    mInterpreter = std::dynamic_pointer_cast<Fast3dWindow>(window)->GetInterpreterWeak();
+    mWindow = Ship::Context::GetInstance()->GetWindow();
+    if (auto fast3dWindow = std::dynamic_pointer_cast<Fast3dWindow>(mWindow))
+        mInterpreter = fast3dWindow->GetInterpreterWeak();
 
-    switch (window->GetWindowBackend()) {
+    switch (mWindow->GetWindowBackend()) {
         case WindowBackend::FAST3D_SDL_OPENGL:
             SDL_SetHint(SDL_HINT_TOUCH_MOUSE_EVENTS, "1");
             if (Ship::Context::GetInstance()->GetConsoleVariables()->GetInteger(CVAR_ALLOW_BACKGROUND_INPUTS, 1)) {
@@ -121,8 +121,7 @@ void Fast3dGui::ImGuiWMInit() {
 }
 
 void Fast3dGui::ImGuiWMShutdown() {
-    auto window = Ship::Context::GetInstance()->GetWindow();
-    switch (window->GetWindowBackend()) {
+    switch (mWindow->GetWindowBackend()) {
 #ifdef ENABLE_OPENGL
         case WindowBackend::FAST3D_SDL_OPENGL:
             ImGui_ImplSDL2_Shutdown();
@@ -141,11 +140,13 @@ void Fast3dGui::ImGuiWMShutdown() {
         default:
             break;
     }
+
+    mWindow = nullptr;
 }
 
 void Fast3dGui::ImGuiBackendInit() {
-    auto window = Ship::Context::GetInstance()->GetWindow();
-    switch (window->GetWindowBackend()) {
+    mBackendWindow = Ship::Context::GetInstance()->GetWindow();
+    switch (mBackendWindow->GetWindowBackend()) {
 #ifdef ENABLE_OPENGL
         case WindowBackend::FAST3D_SDL_OPENGL:
 #ifdef __APPLE__
@@ -178,8 +179,7 @@ void Fast3dGui::ImGuiBackendInit() {
 }
 
 void Fast3dGui::ImGuiBackendShutdown() {
-    auto window = Ship::Context::GetInstance()->GetWindow();
-    switch (window->GetWindowBackend()) {
+    switch (mBackendWindow->GetWindowBackend()) {
 #ifdef ENABLE_OPENGL
         case WindowBackend::FAST3D_SDL_OPENGL:
             ImGui_ImplOpenGL3_Shutdown();
@@ -198,11 +198,12 @@ void Fast3dGui::ImGuiBackendShutdown() {
         default:
             break;
     }
+
+    mBackendWindow = nullptr;
 }
 
 void Fast3dGui::ImGuiBackendNewFrame() {
-    auto window = Ship::Context::GetInstance()->GetWindow();
-    switch (window->GetWindowBackend()) {
+    switch (mBackendWindow->GetWindowBackend()) {
 #ifdef ENABLE_OPENGL
         case WindowBackend::FAST3D_SDL_OPENGL:
             ImGui_ImplOpenGL3_NewFrame();
@@ -228,8 +229,7 @@ void Fast3dGui::ImGuiBackendNewFrame() {
 }
 
 void Fast3dGui::ImGuiWMNewFrame() {
-    auto window = Ship::Context::GetInstance()->GetWindow();
-    switch (window->GetWindowBackend()) {
+    switch (mWindow->GetWindowBackend()) {
         case WindowBackend::FAST3D_SDL_OPENGL:
         case WindowBackend::FAST3D_SDL_METAL:
             ImGui_ImplSDL2_NewFrame();
@@ -257,8 +257,7 @@ void Fast3dGui::RefreshImGuiGamepads() {
 }
 
 void Fast3dGui::ImGuiRenderDrawData(ImDrawData* data) {
-    auto window = Ship::Context::GetInstance()->GetWindow();
-    switch (window->GetWindowBackend()) {
+    switch (mWindow->GetWindowBackend()) {
 #ifdef ENABLE_OPENGL
         case WindowBackend::FAST3D_SDL_OPENGL:
             ImGui_ImplOpenGL3_RenderDrawData(data);
@@ -288,9 +287,8 @@ void Fast3dGui::DrawFloatingWindows() {
         return;
     }
 
-    auto window = Ship::Context::GetInstance()->GetWindow();
     // OpenGL requires extra platform handling for the GL context
-    if (window->GetWindowBackend() == WindowBackend::FAST3D_SDL_OPENGL && mImpl.Opengl.Context != nullptr) {
+    if (mWindow->GetWindowBackend() == WindowBackend::FAST3D_SDL_OPENGL && mImpl.Opengl.Context != nullptr) {
         // Backup window and context before calling RenderPlatformWindowsDefault
         SDL_Window* backupCurrentWindow = SDL_GL_GetCurrentWindow();
         SDL_GLContext backupCurrentContext = SDL_GL_GetCurrentContext();