Changes from PR #989 causing issues with texture packs

[leggettc18]

Recently in Shipwright we are having some lag spikes while using the Djippi's 3DS Experience texture/resource pack (https://gamebanana.com/mods/477979). Specifically, the Market lags a lot on my PC, and Hyrule Field has a few lag spikes as well. I have isolated the changes to PR #989, and I confirmed that reverting just that commit in that PR fixes the issue. I have not been able to isolate what specifically about that commit is the issue, as it is a pretty meaty commit. @koplas if you have any thoughts about what could be the issue here they would be much appreciated!

[koplas]

I didn't test the performance with texture packs, so I missed the problem it introduces with alt-assets. Can you check if this commit already fixes your problem: c74463f860b01d66fad268bae4f916dc1aad2d89.

[Djipi71]

I have test with map replacement and it slowdown a lot

[leggettc18]

I didn't test the performance with texture packs, so I missed the problem it introduces with alt-assets. Can you check if this commit already fixes your problem: c74463f860b01d66fad268bae4f916dc1aad2d89.

This commit does fix the Market with resource pack on my PC, Djipi did you mean you tested current LUS with map replacement or the patch that Koplas linked?

[koplas]

I didn't test the performance with texture packs, so I missed the problem it introduces with alt-assets. Can you check if this commit already fixes your problem: c74463f860b01d66fad268bae4f916dc1aad2d89.

This commit does fix the Market with resource pack on my PC, Djipi did you mean you tested current LUS with map replacement or the patch that Koplas linked?

Thank you for testing, I will prepare a pull request.

[koplas]

I have test with map replacement and it slowdown a lot

I am currently testing a patch that reduces memory copies, which improves performance with large asset files (e.g. 4k textures).
Can you provide a profile trace? This would reduce guess work for me.