Fix ConfigurationValidator incorrectly validating non-existent CommerceConfiguration (#579)

* Initial plan

* Fix ConfigurationValidator to properly check if CommerceConfiguration exists and add tests

Co-authored-by: petrinecp <5637849+petrinecp@users.noreply.github.com>

* Fix code formatting to pass dotnet format verification

Co-authored-by: petrinecp <5637849+petrinecp@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: petrinecp <5637849+petrinecp@users.noreply.github.com>

Author: Copilot

Migration.Tool.CLI/ConfigurationValidator.cs

@@ -161,7 +161,7 @@ public static IEnumerable<ValidationMessage> GetValidationErrors(IConfigurationR
         #region Commerce configuration validation
 
         var commerceConfiguration = settings?.GetSection(ConfigurationNames.CommerceConfiguration);
-        if (commerceConfiguration is not null)
+        if (commerceConfiguration?.Exists() == true)
         {
             var commerceSiteNames = commerceConfiguration.GetSection(ConfigurationNames.CommerceSiteNames).Get<List<string>?>();
             if (commerceSiteNames is null || commerceSiteNames.Count == 0)

Migration.Tool.Tests/ConfigurationValidatorTests.cs

@@ -0,0 +1,73 @@
+using Microsoft.Extensions.Configuration;
+using Migration.Tool.CLI;
+
+namespace Migration.Tool.Tests;
+
+public class ConfigurationValidatorTests
+{
+    [Fact]
+    public void GetValidationErrors_WhenCommerceConfigurationSectionDoesNotExist_ShouldNotReturnValidationErrors()
+    {
+        // Arrange - Create configuration without CommerceConfiguration section
+        var configuration = new ConfigurationBuilder()
+            .AddInMemoryCollection(new Dictionary<string, string?>
+            {
+                ["Settings:KxConnectionString"] = "Server=localhost;Database=Kentico;",
+                ["Settings:XbyKDirPath"] = "C:\\XbyK",
+                ["Settings:XbyKApiSettings:ConnectionStrings:CMSConnectionString"] = "Server=localhost;Database=XbyK;"
+            })
+            .Build();
+
+        // Act
+        var errors = ConfigurationValidator.GetValidationErrors(configuration).ToList();
+
+        // Assert - Should not contain CommerceConfiguration validation error
+        Assert.DoesNotContain(errors, e => e.Message.Contains("CommerceConfiguration"));
+    }
+
+    [Fact]
+    public void GetValidationErrors_WhenCommerceConfigurationExistsWithEmptySiteNames_ShouldReturnValidationError()
+    {
+        // Arrange - Create configuration with CommerceConfiguration section containing empty site name
+        var configuration = new ConfigurationBuilder()
+            .AddInMemoryCollection(new Dictionary<string, string?>
+            {
+                ["Settings:KxConnectionString"] = "Server=localhost;Database=Kentico;",
+                ["Settings:XbyKDirPath"] = "C:\\XbyK",
+                ["Settings:XbyKApiSettings:ConnectionStrings:CMSConnectionString"] = "Server=localhost;Database=XbyK;",
+                ["Settings:CommerceConfiguration:CommerceSiteNames:0"] = "" // Empty value
+            })
+            .Build();
+
+        // Act
+        var errors = ConfigurationValidator.GetValidationErrors(configuration).ToList();
+
+        // Assert - Should contain validation error for empty site names
+        Assert.Contains(errors, e => e.Message.Contains("CommerceConfiguration:CommerceSiteNames") &&
+                                     e.Message.Contains("cannot contain empty or whitespace values"));
+    }
+
+    [Fact]
+    public void GetValidationErrors_WhenCommerceConfigurationExistsWithValidSiteNames_ShouldNotReturnCommerceValidationErrors()
+    {
+        // Arrange - Create configuration with valid CommerceConfiguration
+        var configuration = new ConfigurationBuilder()
+            .AddInMemoryCollection(new Dictionary<string, string?>
+            {
+                ["Settings:KxConnectionString"] = "Server=localhost;Database=Kentico;",
+                ["Settings:XbyKDirPath"] = "C:\\XbyK",
+                ["Settings:XbyKApiSettings:ConnectionStrings:CMSConnectionString"] = "Server=localhost;Database=XbyK;",
+                ["Settings:CommerceConfiguration:CommerceSiteNames:0"] = "MySite"
+            })
+            .Build();
+
+        // Act
+        var errors = ConfigurationValidator.GetValidationErrors(configuration).ToList();
+
+        // Assert - Should not contain CommerceConfiguration validation errors
+        Assert.DoesNotContain(errors, e => e.Message.Contains("CommerceConfiguration:CommerceSiteNames") &&
+                                           e.Message.Contains("must contain at least one site name"));
+        Assert.DoesNotContain(errors, e => e.Message.Contains("CommerceConfiguration:CommerceSiteNames") &&
+                                           e.Message.Contains("cannot contain empty or whitespace values"));
+    }
+}

Migration.Tool.Tests/Migration.Tool.Tests.csproj

@@ -19,6 +19,7 @@
 
     <ItemGroup>
         <ProjectReference Include="..\Migration.Tool.Common\Migration.Tool.Common.csproj" />
+        <ProjectReference Include="..\Migration.Tool.CLI\Migration.Tool.CLI.csproj" />
     </ItemGroup>
 
 </Project>