Skip to content

Commit acc936a

Browse files
authored
Merge pull request #404 from Kernel360/develop
m
2 parents 3f6fc58 + d6e4dbd commit acc936a

1 file changed

Lines changed: 28 additions & 22 deletions

File tree

.github/workflows/cd.yml

Lines changed: 28 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,16 @@ jobs:
128128
aws-secret-access-key: ${{ secrets.AWS_IAM_SECRET_KEY }}
129129
aws-region: ${{ env.AWS_DEFAULT_REGION }}
130130

131-
# # 깃허브 액션의 아이피를 인바운드 룰에 임시 등록
132-
# - name: Add Github Actions IP to Security group
133-
# run: |
134-
# aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 22 --cidr ${{ steps.ip.outputs.ipv4 }}/32
135-
# aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8000 --cidr ${{ steps.ip.outputs.ipv4 }}/32
136-
# aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8501 --cidr ${{ steps.ip.outputs.ipv4 }}/32
137-
# aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8502 --cidr ${{ steps.ip.outputs.ipv4 }}/32
131+
# 깃허브 액션의 아이피를 인바운드 룰에 임시 등록
132+
- name: Add Github Actions IP to Security group
133+
run: |
134+
aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 22 --cidr ${{ steps.ip.outputs.ipv4 }}/32
135+
aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 80 --cidr ${{ steps.ip.outputs.ipv4 }}/32
136+
aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 443 --cidr ${{ steps.ip.outputs.ipv4 }}/32
137+
aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8000 --cidr ${{ steps.ip.outputs.ipv4 }}/32
138+
aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8501 --cidr ${{ steps.ip.outputs.ipv4 }}/32
139+
aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8502 --cidr ${{ steps.ip.outputs.ipv4 }}/32
140+
aws ec2 authorize-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 4444 --cidr ${{ steps.ip.outputs.ipv4 }}/32
138141
139142
# 블루/그린 헬스체크로 변수 초기화
140143
- name: Blue/Green health check
@@ -191,13 +194,13 @@ jobs:
191194
sudo docker-compose up -d
192195
if: ${{ env.TARGET_UPSTREAM == 'green' }}
193196

194-
- name: Check the deployed prod1 service URL
195-
uses: jtalk/url-health-check-action@v3
196-
with:
197-
url: http://${{ env.STOPPED_IP }}:8501/environment
198-
# 총 5번 하는데, 15초의 간격을 두고함. 이때까지 응답이 정상이 아니라면 배포 실패
199-
max-attempts: 5 # Optional, defaults to 1
200-
retry-delay: 15s # Optional, only applicable to max-attempts > 1
197+
# - name: Check the deployed prod1 service URL
198+
# uses: jtalk/url-health-check-action@v3
199+
# with:
200+
# url: http://${{ env.STOPPED_IP }}:8501/environment
201+
# # 총 5번 하는데, 15초의 간격을 두고함. 이때까지 응답이 정상이 아니라면 배포 실패
202+
# max-attempts: 5 # Optional, defaults to 1
203+
# retry-delay: 15s # Optional, only applicable to max-attempts > 1
201204
#
202205
# - name: Check the deployed prod2 service URL
203206
# uses: jtalk/url-health-check-action@v3
@@ -254,11 +257,14 @@ jobs:
254257
docker rm prod2
255258
if: ${{ env.TARGET_UPSTREAM == 'green' }}
256259

257-
# # 깃허브 러너 아이피를 인바운드 룰에서 제거
258-
# - name: Remove Github Actions IP from security group
259-
# # if: always()를 해놓으면 무조건 실행됨. 따라서 위에서 deploy가 실패해도 인바운드 룰로 열어놨던 ip를 모두 닫음.
260-
# if: always()
261-
# run: |
262-
# aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 22 --cidr ${{ steps.ip.outputs.ipv4 }}/32
263-
# aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 80 --cidr ${{ steps.ip.outputs.ipv4 }}/32
264-
# aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8080 --cidr ${{ steps.ip.outputs.ipv4 }}/32
260+
# 깃허브 러너 아이피를 인바운드 룰에서 제거
261+
- name: Remove Github Actions IP from security group
262+
# if: always()를 해놓으면 무조건 실행됨. 따라서 위에서 deploy가 실패해도 인바운드 룰로 열어놨던 ip를 모두 닫음.
263+
if: always()
264+
run: |
265+
aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 22 --cidr ${{ steps.ip.outputs.ipv4 }}/32
266+
aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 80 --cidr ${{ steps.ip.outputs.ipv4 }}/32
267+
aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 443 --cidr ${{ steps.ip.outputs.ipv4 }}/32
268+
aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8000 --cidr ${{ steps.ip.outputs.ipv4 }}/32
269+
aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8501 --cidr ${{ steps.ip.outputs.ipv4 }}/32
270+
aws ec2 revoke-security-group-ingress --group-name ${{ secrets.AWS_SG_NAME }} --protocol tcp --port 8502 --cidr ${{ steps.ip.outputs.ipv4 }}/32

0 commit comments

Comments
 (0)