-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
Here are my feedback and questions for the Keyboardly dev environment
Disclaimer: this based only reading the doc and the source code of the repo, not actually trying it
- The add-on is packaged as an Android dynamic feature module, how this is packaged and distributed?
- The setup is way too complicated
- Conventions for classes are all over the place, for what?
- There should be an easier way to set up the base classes, DI with Dagger is not a good default, it causes too many noises
- There should be a strongly opinionated default for container
View. (MATCH_PARENTwith min height 250dp for example) - Data binding and Dagger should not be in the example
- Maybe a simpler navigation setup and not involving safe-arg?
- R8 rules could be moved to the app module only
- Stronger convention of resources with resource prefix
Metadata
Metadata
Assignees
Labels
No labels