Skip to content

Feedbacks & Questions Regarding the Dev Environment #3

@esafirm

Description

@esafirm

Here are my feedback and questions for the Keyboardly dev environment

Disclaimer: this based only reading the doc and the source code of the repo, not actually trying it

  1. The add-on is packaged as an Android dynamic feature module, how this is packaged and distributed?
  2. The setup is way too complicated
    • Conventions for classes are all over the place, for what?
    • There should be an easier way to set up the base classes, DI with Dagger is not a good default, it causes too many noises
    • There should be a strongly opinionated default for container View. (MATCH_PARENT with min height 250dp for example)
    • Data binding and Dagger should not be in the example
    • Maybe a simpler navigation setup and not involving safe-arg?
    • R8 rules could be moved to the app module only
  3. Stronger convention of resources with resource prefix

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions