feat(property): freeze properties after realize

Author: khachi

src/qom/property.c

@@ -1,10 +1,13 @@
 #include <assert.h>
 #include <ctype.h>
 #include <errno.h>
+#include <stdbool.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include "miniqom/property.h"
+#include "miniqom/error.h"
+#include "miniqom/object.h"
 #include "miniqom/type.h"
 
 ObjectClass *object_class_new(Type *type)
@@ -116,9 +119,23 @@ static bool parse_u64(const char *text, uint64_t *value)
 bool object_property_set_from_string(Object *obj, const char *name,
                                      const char *text, Error *err)
 {
-    const Property *property = object_property_find(obj, name);
+    const Property *property;
     PropertyValue value = {0};
 
+    if (!obj || !name || !text)
+    {
+        error_set(err, "invalid property set arguments");
+        return false;
+    }
+
+    if (object_is_realized(obj))
+    {
+        error_set(err, "object is already realized");
+        return false;
+    }
+
+    property = object_property_find(obj, name);
+
     if (!property)
     {
         error_set(err, "property not found");
@@ -178,4 +195,4 @@ bool object_property_get(Object *obj,
         return false;
     }
     return property->get(obj, value, err);
-}
+}

tests/test_qom.c

@@ -1,6 +1,8 @@
 #include <assert.h>
+#include <stdio.h>
 #include <string.h>
 
+#include "miniqom/error.h"
 #include "miniqom/memory.h"
 #include "miniqom/object.h"
 #include "miniqom/property.h"
@@ -186,9 +188,36 @@ int main(void)
     assert(backend->parent_obj.size == 2ULL * 1024 * 1024 * 1024);
     assert(!strcmp(backend->parent_obj.swap_storage, "file:///swap"));
 
-    // ====== Test property ======
+    // ====== Freeze properties ======
+    //
+    Object *property_object;
+    property_object = object_new(TYPE_MEMORY_BACKEND_MEMFD);
+    assert(property_object != NULL);
+
     PropertyValue property_value;
+    error_clear(&err);
+
+    assert(object_property_set_from_string(property_object,
+                                           "size",
+                                           "2G",
+                                           &err));
+
+    assert(object_realize(property_object, &err));
+    assert(object_is_realized(property_object));
+
+    assert(!object_property_set_from_string(property_object,
+                                            "size", "4G",
+                                            &err));
 
+    assert(!strcmp(err.message, "object is already realized"));
+
+    assert(object_property_get(property_object,
+                               "size",
+                               &property_value,
+                               &err));
+
+    assert(property_value.u64 == 2ULL * 1024 * 1024 * 1024);
+    // ====== Test property ======
     assert(object_property_get(mem0, "size",
                                &property_value, &err));
     assert(property_value.u64 == 2ULL * 1024 * 1024 * 1024);
@@ -252,4 +281,4 @@ int main(void)
     // ======= Release test resources ======
     object_free(root);
     return 0;
-}
+}