dedupe changesets

Author: nedredmond

.changeset/spotty-queens-move.md

@@ -0,0 +1,5 @@
+---
+'mock-workspace': patch
+---
+
+This doesn't matter

NaN.json

@@ -0,0 +1,4 @@
+{
+  "changesets": [],
+  "releases": []
+}

__tests__/main.test.ts

@@ -12,27 +12,11 @@ import * as github from '@actions/github'
 import * as main from '../src/main'
 import * as utils from '../src/utils'
 
-// Mock the GitHub Actions core library
+// Mock the GitHub Actions library
 const infoMock = jest.spyOn(core, 'info')
-const setFailedMock = jest
-  .spyOn(core, 'setFailed')
-  .mockImplementation(console.debug)
-const inputMock = jest
-  .spyOn(core, 'getInput')
-  .mockImplementation((name: string): string => {
-    switch (name) {
-      case 'changed_files':
-        return JSON.stringify([
-          './packages/pkg1/file1.css',
-          './packages/pkgB/file2.tsx'
-        ])
-      default:
-        return ''
-    }
-  })
-
-jest.spyOn(exec, 'exec').mockImplementation(async () => 0)
-const getExecOutputMock = jest.spyOn(exec, 'getExecOutput')
+const setFailedMock = jest.spyOn(core, 'setFailed')
+const inputMock = jest.spyOn(core, 'getInput')
+const execSpy = jest.spyOn(exec, 'exec')
 
 const originalContext = github.context
 
@@ -41,7 +25,18 @@ const runMock = jest.spyOn(main, 'run')
 
 describe('action', () => {
   beforeEach(() => {
-    jest.clearAllMocks()
+    inputMock.mockImplementation((name: string): string => {
+      switch (name) {
+        case 'changed_files':
+          return JSON.stringify([
+            './packages/pkg1/file1.css',
+            './packages/pkgB/file2.tsx'
+          ])
+        default:
+          return ''
+      }
+    })
+    setFailedMock.mockImplementation(console.debug)
   })
 
   afterEach(() => {
@@ -84,7 +79,8 @@ describe('action', () => {
         }
       }
     })
-    getExecOutputMock
+    jest
+      .spyOn(exec, 'getExecOutput')
       // workspaces info
       .mockImplementationOnce(async () => ({
         stdout: JSON.stringify({
@@ -101,6 +97,12 @@ describe('action', () => {
         stderr: '',
         exitCode: 0
       }))
+      // check changeset installed
+      .mockImplementationOnce(async () => ({
+        stdout: '',
+        stderr: '',
+        exitCode: 0
+      }))
       // changeset info
       .mockImplementationOnce(async () => ({
         stdout: `🦋  info Packages to be bumped at patch:
@@ -123,6 +125,7 @@ describe('action', () => {
     // Assert
     expect(runMock).toHaveReturned()
     expect(setFailedMock).not.toHaveBeenCalled()
+    expect(execSpy).not.toHaveBeenCalled()
 
     // Verify that all of the core library functions were called correctly
     expect(infoMock).toHaveBeenNthCalledWith(
@@ -135,6 +138,74 @@ describe('action', () => {
     )
   })
 
+  it('installs changeset when not installed', async () => {
+    // Arrange
+    jest.spyOn(utils, 'getChangesets').mockImplementation(
+      async (): Promise<utils.Changesets> =>
+        Promise.resolve({
+          releases: [
+            {
+              name: '@owner/pkg1',
+              type: 'patch'
+            },
+            {
+              name: '@owner/pkgB',
+              type: 'patch'
+            }
+          ]
+        })
+    )
+    Object.defineProperty(github, 'context', {
+      value: {
+        ...originalContext,
+        eventName: 'pull_request',
+        payload: {
+          pull_request: {
+            head: {
+              sha: '1234567890'
+            },
+            base: {
+              ref: 'main'
+            }
+          }
+        }
+      }
+    })
+    jest
+      .spyOn(exec, 'getExecOutput')
+      // workspaces info
+      .mockImplementationOnce(async () => ({
+        stdout: JSON.stringify({
+          type: 'log',
+          data: JSON.stringify({
+            '@owner/pkg1': {
+              location: './packages/pkg1'
+            },
+            '@owner/pkgB': {
+              location: './packages/pkgB'
+            }
+          })
+        }),
+        stderr: '',
+        exitCode: 0
+      }))
+      // check changeset installed
+      .mockImplementationOnce(async () => ({
+        stdout: '',
+        stderr: '',
+        exitCode: 1
+      }))
+
+    // Act
+    await main.run()
+
+    // Assert
+    expect(runMock).toHaveReturned()
+
+    // Verify that all of the core library functions were called correctly
+    expect(execSpy).toHaveBeenCalledWith('yarn add @changesets/cli@latest -W')
+  })
+
   it('fails when there are packages that need changeset entries', async () => {
     // Arrange
     Object.defineProperty(github, 'context', {
@@ -153,7 +224,8 @@ describe('action', () => {
         }
       }
     })
-    getExecOutputMock
+    jest
+      .spyOn(exec, 'getExecOutput')
       // workspaces info
       .mockImplementationOnce(async () => ({
         stdout: JSON.stringify({
@@ -170,6 +242,12 @@ describe('action', () => {
         stderr: '',
         exitCode: 0
       }))
+      // changeset installed
+      .mockImplementationOnce(async () => ({
+        stdout: '',
+        stderr: '',
+        exitCode: 0
+      }))
       // changeset info
       .mockImplementationOnce(async () => ({
         stdout: '',
@@ -244,7 +322,8 @@ describe('action', () => {
         }
       }
     })
-    getExecOutputMock
+    jest
+      .spyOn(exec, 'getExecOutput')
       // workspaces info
       .mockImplementationOnce(async () => ({
         stdout: JSON.stringify({
@@ -291,7 +370,8 @@ describe('action', () => {
         }
       }
     })
-    getExecOutputMock
+    jest
+      .spyOn(exec, 'getExecOutput')
       // workspaces info
       .mockImplementationOnce(async () => ({
         stdout: '',
@@ -326,7 +406,8 @@ describe('action', () => {
         }
       }
     })
-    getExecOutputMock
+    jest
+      .spyOn(exec, 'getExecOutput')
       // workspaces info
       .mockImplementationOnce(async () => ({
         stdout: JSON.stringify({
@@ -343,6 +424,12 @@ describe('action', () => {
         stderr: '',
         exitCode: 0
       }))
+      // changeset installed
+      .mockImplementationOnce(async () => ({
+        stdout: '',
+        stderr: '',
+        exitCode: 0
+      }))
       // changeset info
       .mockImplementationOnce(async () => ({
         stdout: JSON.stringify(`🦋  info Packages to be bumped at patch:

dist/index.js

@@ -72,7 +72,7 @@
   "devDependencies": {
     "@changesets/cli": "^2.26.2",
     "@types/jest": "^29.5.5",
-    "@types/node": "^20.6.5",
+    "@types/node": "^18.17.1",
     "@typescript-eslint/eslint-plugin": "^6.7.3",
     "@typescript-eslint/parser": "^6.7.2",
     "@vercel/ncc": "^0.38.0",

package.json

@@ -75,10 +75,17 @@ export async function run(): Promise<void> {
       return
     }
 
-    // right now, the only way to access JSON output is to create a file,
-    //   so we are just going to work with the pretty-printed output
+    const changesetExists = await exec.getExecOutput(
+      `yarn changeset --version`,
+      undefined,
+      { ignoreReturnCode: true }
+    )
+    if (changesetExists.exitCode === 1) {
+      core.info('Installing changeset CLI')
+      await exec.exec(`yarn add @changesets/cli@latest -W`)
+    }
+
     const filePath = `${github.context.runId}.json`
-    await exec.exec(`yarn add @changesets/cli@latest -W`)
     const changesetResult = await exec.getExecOutput(
       `yarn changeset status --since origin/${base} --output ${filePath}`,
       undefined,

src/main.ts

@@ -1114,10 +1114,10 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-12.20.55.tgz#c329cbd434c42164f846b909bd6f85b5537f6240"
   integrity sha512-J8xLz7q2OFulZ2cyGTLE1TbbZcjpno7FaN6zdJNrgAdrJ+DZzh/uFR6YrTb4C+nXakvud8Q4+rbhoIWlYQbUFQ==
 
-"@types/node@^20.6.5":
-  version "20.6.5"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.6.5.tgz#4c6a79adf59a8e8193ac87a0e522605b16587258"
-  integrity sha512-2qGq5LAOTh9izcc0+F+dToFigBWiK1phKPt7rNhOqJSr35y8rlIBjDwGtFSgAI6MGIhjwOVNSQZVdJsZJ2uR1w==
+"@types/node@^18.17.1":
+  version "18.18.0"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-18.18.0.tgz#bd19d5133a6e5e2d0152ec079ac27c120e7f1763"
+  integrity sha512-3xA4X31gHT1F1l38ATDIL9GpRLdwVhnEFC8Uikv5ZLlXATwrCYyPq7ZWHxzxc3J/30SUiwiYT+bQe0/XvKlWbw==
 
 "@types/normalize-package-data@^2.4.0":
   version "2.4.1"