Access json output file instead of parsing CLI (#6)

Author: nedredmond

.changeset/brown-tips-roll.md

@@ -0,0 +1,5 @@
+---
+'mock-workspace': patch
+---
+
+fake entry

.changeset/fast-pigs-trade.md

@@ -0,0 +1,2 @@
+---
+---

__tests__/main.test.ts

@@ -53,6 +53,21 @@ describe('action', () => {
 
   it('completes when there is a changeset entry for every package', async () => {
     // Arrange
+    jest.spyOn(utils, 'getChangesets').mockImplementation(
+      async (): Promise<utils.Changesets> =>
+        Promise.resolve({
+          releases: [
+            {
+              name: '@owner/pkg1',
+              type: 'patch'
+            },
+            {
+              name: '@owner/pkgB',
+              type: 'patch'
+            }
+          ]
+        })
+    )
     Object.defineProperty(github, 'context', {
       value: {
         ...originalContext,

__tests__/utils.test.ts

@@ -1,6 +1,9 @@
-import { getBaseAndHead } from '../src/utils'
+import { getBaseAndHead, getChangesets } from '../src/utils'
 import { Context } from '@actions/github/lib/context'
 
+import fs from 'fs/promises'
+jest.mock('fs/promises')
+
 const contextData: Context = {
   payload: {},
   eventName: '',
@@ -137,4 +140,13 @@ describe('utils', () => {
       expect(getBaseAndHead(context)).toEqual([])
     })
   })
+  describe('getChangesets', () => {
+    it('returns the parsed changesets file', async () => {
+      fs.readFile = jest
+        .fn()
+        .mockResolvedValue(JSON.stringify({ releases: [] }))
+      const changesets = await getChangesets('changesets.json')
+      expect(changesets).toEqual({ releases: [] })
+    })
+  })
 })

dist/index.js

@@ -72,7 +72,7 @@
   "devDependencies": {
     "@changesets/cli": "^2.26.2",
     "@types/jest": "^29.5.5",
-    "@types/node": "^20.6.3",
+    "@types/node": "^20.6.5",
     "@typescript-eslint/eslint-plugin": "^6.7.2",
     "@typescript-eslint/parser": "^6.7.2",
     "@vercel/ncc": "^0.38.0",

mock-workspace/fakechange

@@ -1,7 +1,7 @@
 import * as core from '@actions/core'
 import * as exec from '@actions/exec'
 import * as github from '@actions/github'
-import { getBaseAndHead } from './utils'
+import { getBaseAndHead, getChangesets } from './utils'
 
 /**
  * The main function for the action.
@@ -77,9 +77,10 @@ export async function run(): Promise<void> {
 
     // right now, the only way to access JSON output is to create a file,
     //   so we are just going to work with the pretty-printed output
+    const filePath = `${github.context.runId}.json`
     await exec.exec(`yarn add @changesets/cli@latest -W`)
     const changesetResult = await exec.getExecOutput(
-      `yarn changeset status --since origin/${base}`,
+      `yarn changeset status --since origin/${base} --output ${filePath}`,
       undefined,
       { ignoreReturnCode: true }
     )
@@ -91,14 +92,11 @@ export async function run(): Promise<void> {
     }
 
     // parse out the package names from the pretty-printed changeset output
-    const changesetEntries =
-      changesetResult.exitCode === 1
-        ? []
-        : changesetResult.stdout
-            .split('\n')
-            .map((line: string) => line.trim())
-            .filter((line: string) => line.startsWith('🦋  - '))
-            .map((line: string) => line.replace('🦋  - ', ''))
+    let changesetEntries: string[] = []
+    if (changesetResult.exitCode !== 1) {
+      const changesets = await getChangesets(filePath)
+      changesetEntries = changesets.releases.map(release => release.name)
+    }
 
     const changesetEntriesNeeded = packageNamesArray.filter(
       packageName => !changesetEntries.includes(packageName)

package.json

@@ -1,4 +1,5 @@
 import type { Context } from '@actions/github/lib/context'
+import * as fs from 'fs/promises'
 
 export const getBaseAndHead = (context: Context): string[] => {
   switch (context.eventName) {
@@ -13,3 +14,19 @@ export const getBaseAndHead = (context: Context): string[] => {
   }
   return []
 }
+
+type Release = {
+  name: string
+  type: 'major' | 'minor' | 'patch'
+  oldVersion?: string
+  changeSets?: string[]
+}
+
+export type Changesets = {
+  releases: Release[]
+}
+
+export const getChangesets = async (path: string): Promise<Changesets> => {
+  const changesetsFile = await fs.readFile(path, 'utf8')
+  return JSON.parse(changesetsFile) as Changesets
+}

src/main.ts

@@ -1104,7 +1104,7 @@
   resolved "https://registry.yarnpkg.com/@types/minimist/-/minimist-1.2.2.tgz#ee771e2ba4b3dc5b372935d549fd9617bf345b8c"
   integrity sha512-jhuKLIRrhvCPLqwPcx6INqmKeiA5EWrsCOPhrlFSrbrmU4ZMPjj5Ul/oLCMDO98XRUIwVm78xICz4EPCektzeQ==
 
-"@types/node@*", "@types/node@^20.6.3":
+"@types/node@*":
   version "20.6.3"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-20.6.3.tgz#5b763b321cd3b80f6b8dde7a37e1a77ff9358dd9"
   integrity sha512-HksnYH4Ljr4VQgEy2lTStbCKv/P590tmPe5HqOnv9Gprffgv5WXAY+Y5Gqniu0GGqeTCUdBnzC3QSrzPkBkAMA==
@@ -1114,6 +1114,11 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-12.20.55.tgz#c329cbd434c42164f846b909bd6f85b5537f6240"
   integrity sha512-J8xLz7q2OFulZ2cyGTLE1TbbZcjpno7FaN6zdJNrgAdrJ+DZzh/uFR6YrTb4C+nXakvud8Q4+rbhoIWlYQbUFQ==
 
+"@types/node@^20.6.5":
+  version "20.6.5"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.6.5.tgz#4c6a79adf59a8e8193ac87a0e522605b16587258"
+  integrity sha512-2qGq5LAOTh9izcc0+F+dToFigBWiK1phKPt7rNhOqJSr35y8rlIBjDwGtFSgAI6MGIhjwOVNSQZVdJsZJ2uR1w==
+
 "@types/normalize-package-data@^2.4.0":
   version "2.4.1"
   resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.1.tgz#d3357479a0fdfdd5907fe67e17e0a85c906e1301"