[numeric-no-underscore] PR Feedback

Author: SonicScrewdriver

packages/perseus-core/src/data-schema.ts

@@ -1164,17 +1164,15 @@ export type MathFormat =
     | "pi";
 
 export type PerseusNumericInputAnswerForm = {
-    simplify: PerseusNumericInputSimplify;
+    simplify: PerseusNumericInputSimplify | null | undefined;
     name: MathFormat;
 };
 
 export type PerseusNumericInputSimplify =
     | "required"
     | "correct"
     | "enforced"
-    | "optional"
-    | null
-    | undefined;
+    | "optional";
 
 export type PerseusNumericInputWidgetOptions = {
     // A list of all the possible correct and incorrect answers
@@ -1212,7 +1210,7 @@ export type PerseusNumericInputAnswer = {
     // NOTE: perseus_data.go says this is non-nullable even though we handle null values.
     maxError: number | null | undefined;
     // Unsimplified answers are Ungraded, Accepted, or Wrong. Options: "required", "correct", or "enforced"
-    simplify: PerseusNumericInputSimplify;
+    simplify: PerseusNumericInputSimplify | null | undefined;
 };
 
 export type PerseusNumberLineWidgetOptions = {

packages/perseus/src/widgets/numeric-input/numeric-input.class.tsx

@@ -169,7 +169,9 @@ type RenderProps = {
 const propsTransform = function (
     widgetOptions: PerseusNumericInputWidgetOptions,
 ): RenderProps {
-    const rendererProps: RenderProps & {answers?: any} = {
+    // Omit the answers from the widget options since they are
+    // not needed for rendering the widget.
+    const {answers: _, ...rendererProps} = {
         ...widgetOptions,
         answerForms: unionAnswerForms(
             widgetOptions.answers.map((answer) => {
@@ -183,7 +185,6 @@ const propsTransform = function (
         ),
     };
 
-    delete rendererProps.answers;
     return rendererProps;
 };
 

packages/perseus/src/widgets/numeric-input/utils.test.ts

@@ -1,6 +1,7 @@
+import {mockStrings} from "../../strings";
+
 import {generateExamples, shouldShowExamples, unionAnswerForms} from "./utils";
 
-import type {PerseusStrings} from "../../strings";
 import type {PerseusNumericInputAnswerForm} from "@khanacademy/perseus-core";
 
 describe("generateExamples", () => {
@@ -16,23 +17,15 @@ describe("generateExamples", () => {
                 simplify: "required",
             },
         ];
-        const fakePerseusStrings: Partial<PerseusStrings> = {
-            yourAnswer: "Your answer",
-            integerExample: "Integer example",
-            properExample: "Proper example",
-            simplifiedProperExample: "Simplified proper example",
-        };
+
         const expected = [
-            "Your answer",
-            "Integer example",
-            "Simplified proper example",
+            "**Your answer should be** ",
+            "an integer, like $6$",
+            "a *simplified proper* fraction, like $3/5$",
         ];
 
         // Act
-        const result = generateExamples(
-            answerForms,
-            fakePerseusStrings as PerseusStrings,
-        );
+        const result = generateExamples(answerForms, mockStrings);
 
         // Assert
         expect(result).toEqual(expected);
@@ -54,23 +47,15 @@ describe("generateExamples", () => {
                 simplify: "required",
             },
         ];
-        const fakePerseusStrings: Partial<PerseusStrings> = {
-            yourAnswer: "Your answer",
-            integerExample: "Integer example",
-            properExample: "Proper example",
-            simplifiedProperExample: "Simplified proper example",
-        };
+
         const expected = [
-            "Your answer",
-            "Integer example",
-            "Simplified proper example",
+            "**Your answer should be** ",
+            "an integer, like $6$",
+            "a *simplified proper* fraction, like $3/5$",
         ];
 
         // Act
-        const result = generateExamples(
-            answerForms,
-            fakePerseusStrings as PerseusStrings,
-        );
+        const result = generateExamples(answerForms, mockStrings);
 
         // Assert
         expect(result).toEqual(expected);
@@ -79,19 +64,11 @@ describe("generateExamples", () => {
     it("returns an empty array if no answer forms are provided", () => {
         // Arrange
         const answerForms: readonly PerseusNumericInputAnswerForm[] = [];
-        const fakePerseusStrings: Partial<PerseusStrings> = {
-            yourAnswer: "Your answer",
-            integerExample: "Integer example",
-            properExample: "Proper example",
-            simplifiedProperExample: "Simplified proper example",
-        };
+
         const expected = [];
 
         // Act
-        const result = generateExamples(
-            answerForms,
-            fakePerseusStrings as PerseusStrings,
-        );
+        const result = generateExamples(answerForms, mockStrings);
 
         // Assert
         expect(result).toEqual(expected);