Skip to content

Commit 89819ed

Browse files
authored
[🔥AUDIT🔥] Add cloudbuild.builds.builder to ro github ci account (#20)
🖍 _This is an audit!_ 🖍 ## Summary: We still run cloud builds on PR branches, so the read-only account needs build permissions. Issue: INFRA-XXXX ## Test plan: Test it on [this branch](Khan/internal-services#357) Author: jwbron Auditors: #infra-platform Required Reviewers: Approved By: Checks: ✅ 1 check was successful Pull Request URL: #20
1 parent 1f134f3 commit 89819ed

File tree

1 file changed

+20
-20
lines changed
  • terraform/modules/github-ci-bootstrap

1 file changed

+20
-20
lines changed

terraform/modules/github-ci-bootstrap/main.tf

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,30 +15,30 @@ terraform {
1515
# Define service-to-role mapping
1616
locals {
1717
read_write_roles = {
18-
cloudfunctions = "roles/cloudfunctions.admin"
19-
storage = "roles/storage.admin"
20-
pubsub = "roles/pubsub.admin"
21-
scheduler = "roles/cloudscheduler.admin"
22-
run = "roles/run.admin"
23-
cloudbuild = "roles/cloudbuild.admin"
24-
artifactregistry = "roles/artifactregistry.admin"
25-
secretmanager = "roles/secretmanager.admin"
26-
logging = "roles/logging.admin"
27-
monitoring = "roles/monitoring.admin"
18+
cloudfunctions = "roles/cloudfunctions.admin"
19+
storage = "roles/storage.admin"
20+
pubsub = "roles/pubsub.admin"
21+
scheduler = "roles/cloudscheduler.admin"
22+
run = "roles/run.admin"
23+
cloudbuild = "roles/cloudbuild.builds.builder"
24+
artifactregistry = "roles/artifactregistry.admin"
25+
secretmanager = "roles/secretmanager.admin"
26+
logging = "roles/logging.admin"
27+
monitoring = "roles/monitoring.admin"
2828
}
2929

3030
# Read-only roles for any branch
3131
read_only_roles = {
32-
cloudfunctions = "roles/cloudfunctions.viewer"
33-
storage = "roles/storage.objectViewer"
34-
pubsub = "roles/pubsub.viewer"
35-
scheduler = "roles/cloudscheduler.viewer"
36-
run = "roles/run.viewer"
37-
cloudbuild = "roles/cloudbuild.viewer" # Read-only branches get viewer access
38-
artifactregistry = "roles/artifactregistry.reader"
39-
secretmanager = "roles/secretmanager.viewer"
40-
logging = "roles/logging.viewer"
41-
monitoring = "roles/monitoring.viewer"
32+
cloudfunctions = "roles/cloudfunctions.viewer"
33+
storage = "roles/storage.objectViewer"
34+
pubsub = "roles/pubsub.viewer"
35+
scheduler = "roles/cloudscheduler.viewer"
36+
run = "roles/run.viewer"
37+
cloudbuild = "roles/cloudbuild.builds.builder" # Read-only branches still need build access
38+
artifactregistry = "roles/artifactregistry.reader"
39+
secretmanager = "roles/secretmanager.viewer"
40+
logging = "roles/logging.viewer"
41+
monitoring = "roles/monitoring.viewer"
4242
}
4343

4444
# Parse GitHub repository into org and repo name

0 commit comments

Comments
 (0)