fix helide API thread safety

Author: jeffamstutz

src/devices/helide/HelideDevice.cpp

@@ -207,23 +207,6 @@ const void *HelideDevice::getParameterInfo(ANARIDataType objectType,
       infoType);
 }
 
-// Object + Parameter Lifetime Management /////////////////////////////////////
-
-int HelideDevice::getProperty(ANARIObject object,
-    const char *name,
-    ANARIDataType type,
-    void *mem,
-    uint64_t size,
-    uint32_t mask)
-{
-  if (mask == ANARI_WAIT) {
-    auto lock = scopeLockObject();
-    deviceState()->waitOnCurrentFrame();
-  }
-
-  return helium::BaseDevice::getProperty(object, name, type, mem, size, mask);
-}
-
 // Other HelideDevice definitions /////////////////////////////////////////////
 
 HelideDevice::HelideDevice(ANARIStatusCallback cb, const void *ptr)

src/devices/helide/HelideDevice.h

@@ -70,15 +70,6 @@ struct HelideDevice : public helium::BaseDevice
       const char *infoName,
       ANARIDataType infoType) override;
 
-  // Object + Parameter Lifetime Management ///////////////////////////////////
-
-  int getProperty(ANARIObject object,
-      const char *name,
-      ANARIDataType type,
-      void *mem,
-      uint64_t size,
-      uint32_t mask) override;
-
   /////////////////////////////////////////////////////////////////////////////
   // Helper/other functions and data members
   /////////////////////////////////////////////////////////////////////////////

src/devices/helide/frame/Frame.cpp

@@ -159,6 +159,9 @@ void Frame::renderFrame()
 
     m_frameLastRendered = helium::newTimeStamp();
 
+    // NOTE(jda) - We don't want any anariGetProperty() calls also trying to
+    //             rebuild the Embree scene in parallel to us doing a rebuild.
+    auto worldLock = m_world->scopeLockObject();
     m_world->embreeSceneUpdate();
 
     const auto taskGrainSize = uint2(m_renderer->taskGrainSize());

src/devices/helide/scene/World.cpp

@@ -31,6 +31,9 @@ bool World::getProperty(
   if (name == "bounds" && type == ANARI_FLOAT32_BOX3) {
     if (flags & ANARI_WAIT)
       embreeSceneUpdate();
+    if (!m_embreeScene)
+      return false;
+
     auto bounds = getEmbreeSceneBounds(m_embreeScene);
     for (auto *i : instances()) {
       for (auto *v : i->group()->volumes()) {