Correctly wrap/unwrap DebugLocalVariable ArgNumber in OpConstant#3769
Open
AdamBrouwersHarries wants to merge 2 commits into
Open
Correctly wrap/unwrap DebugLocalVariable ArgNumber in OpConstant#3769AdamBrouwersHarries wants to merge 2 commits into
AdamBrouwersHarries wants to merge 2 commits into
Conversation
|
|
The NonSemantic.Shader.DebugInfo spec requires that the (optional) ArgNumber operand for a DebugLocalVariable operation is the id of a 32-bit OpConstant. This patch ensures that both the LLVM to SPIR-V and SPIR-V to LLVM paths through the translator respect this requirement.
AdamBrouwersHarries
force-pushed
the
debug-local-variable-argnumber
branch
from
f13b82f to
4ebd698
Compare
AdamBrouwersHarries
changed the title
Author
|
Note, this addresses #3768 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NonSemantic.Shader.DebugInfo spec requires that the (optional) ArgNumber operand for a DebugLocalVariable operation is the id of a 32-bit OpConstant.
This patch ensures that both the LLVM to SPIR-V and SPIR-V to LLVM paths through the translator respect this requirement.