build: Downstream Vulkan-ValidationLayers 1.4.319

Author: aqnuep

.github/workflows/sdk_android_build.yml

@@ -58,7 +58,6 @@ jobs:
     steps:
     - name: Clone repository
       uses: actions/checkout@v4
-    - uses: lukka/get-cmake@latest
     - uses: actions/setup-python@v5
       with:
         python-version: '3.10'

.github/workflows/vvl.yml

@@ -53,22 +53,21 @@ jobs:
   linux:
     needs: check_vvl
     runs-on: ubuntu-24.04
-    name: "linux (address sanitizer, ${{matrix.config}}, robinhood ${{matrix.robin_hood}} )"
+    name: "linux (address sanitizer, ${{matrix.config}}, custom_hash_map ${{matrix.custom_hash_map}} )"
     strategy:
       fail-fast: false
       matrix:
         config: [ release ]
-        # Test with Robin Hood disabled
+        # Test with Custom hash map both enabled and disabled
         # Chromium build, and some package managers don't use it.
-        robin_hood: [ "ON", "OFF" ]
+        custom_hash_map: [ "ON", "OFF" ]
     steps:
       - uses: actions/checkout@v4
-      - uses: lukka/get-cmake@latest
       - uses: hendrikmuhs/[email protected]
         with:
-          key: ${{ matrix.config }}-address-${{matrix.robin_hood}}
-      - run: sudo apt-get -qq update && sudo apt-get install -y libwayland-dev xorg-dev
-      - run: python scripts/tests_vksc.py --build --config ${{ matrix.config }} --cmake='-DUSE_ROBIN_HOOD_HASHING=${{matrix.robin_hood}}'
+          key: ${{ matrix.config }}-address-${{matrix.custom_hash_map}}
+      - run: sudo apt-get -qq update && sudo apt-get install -y libwayland-dev xorg-dev xvfb
+      - run: python scripts/tests_vksc.py --build --config ${{ matrix.config }} --cmake='-DUSE_CUSTOM_HASH_MAP=${{matrix.custom_hash_map}}'
         env:
           CFLAGS: -fsanitize=address
           CXXFLAGS: -fsanitize=address
@@ -93,61 +92,84 @@ jobs:
           VKSC_DEVSIM_PROFILE_FILE: ${{ github.workspace }}/tests/vulkansc/device_profiles/max_profile.json
           VKSC_LAYER_TESTS_NO_SPV_DEBUG_INFO: TRUE
 
-  # Make sure a debug version builds, but no need to run tests on it (since we do with release already)
-  linux-debug:
+  linux-tsan:
     needs: check_vvl
     runs-on: ubuntu-24.04
-    name: "linux (Build Only, ${{matrix.config}}, robinhood ${{matrix.robin_hood}} )"
+    name: "linux (thread sanitizer, ${{matrix.config}}, custom_hash_map ${{matrix.custom_hash_map}} )"
     strategy:
       fail-fast: false
       matrix:
-        config: [ debug ]
-        robin_hood: [ "ON" ]
+        # Have found over time debug finds nothing extra, while taking the longest and using the most CI minutes.
+        config: [ release ]
+        custom_hash_map: [ "ON" ]
+
     steps:
       - uses: actions/checkout@v4
-      - uses: lukka/get-cmake@latest
       - uses: hendrikmuhs/[email protected]
         with:
-          key: ${{ matrix.config }}-buildOnly-${{matrix.robin_hood}}
-      - run: sudo apt-get -qq update && sudo apt-get install -y libwayland-dev xorg-dev
-      - run: python scripts/tests_vksc.py --build --config ${{ matrix.config }} --cmake='-DUSE_ROBIN_HOOD_HASHING=${{matrix.robin_hood}}'
+          key: ${{ matrix.config }}-thread-${{matrix.custom_hash_map}}
+      - run: sudo apt-get -qq update && sudo apt-get install -y libwayland-dev xorg-dev xvfb
+      - run: python scripts/tests_vksc.py --build --config ${{ matrix.config }} --cmake='-DUSE_CUSTOM_HASH_MAP=${{matrix.custom_hash_map}}'
         env:
+          CFLAGS: -fsanitize=thread
+          CXXFLAGS: -fsanitize=thread
+          LDFLAGS: -fsanitize=thread
           CMAKE_C_COMPILER_LAUNCHER: ccache
           CMAKE_CXX_COMPILER_LAUNCHER: ccache
+      # Thread Sanitize will take about 9x longer to run than Address Sanitize.
+      # The main reason we have Max Core and Min Core is to catch issues with Vulkan 1.x vs Vulkan 1.y version issues.
+      # In effort to reduce the bottle neck time in testing, skipping these for Thread Sanitize.
+      - name: Test Max Profile
+        run: python scripts/tests_vksc.py --test --tsan
+        env:
+          VKSC_DEVSIM_PROFILE_FILE: ${{ github.workspace }}/tests/vulkansc/device_profiles/max_profile.json
 
-  linux-tsan:
+  linux-ubsan:
     needs: check_vvl
     runs-on: ubuntu-24.04
-    name: "linux (thread sanitizer, ${{matrix.config}}, robinhood ${{matrix.robin_hood}} )"
+    name: "linux (undefined behavior sanitizer, debug)"
     strategy:
       fail-fast: false
-      matrix:
-        # Have found over time debug finds nothing extra, while taking the longest and using the most CI minutes.
-        config: [ release ]
-        robin_hood: [ "ON" ]
-
     steps:
       - uses: actions/checkout@v4
-      - uses: lukka/get-cmake@latest
       - uses: hendrikmuhs/[email protected]
         with:
-          key: ${{ matrix.config }}-thread-${{matrix.robin_hood}}
+          key: linux-ubsan
       - run: sudo apt-get -qq update && sudo apt-get install -y libwayland-dev xorg-dev
-      - run: python scripts/tests_vksc.py --build --config ${{ matrix.config }} --cmake='-DUSE_ROBIN_HOOD_HASHING=${{matrix.robin_hood}}'
+      - run: python scripts/tests_vksc.py --build --config debug --cmake='-DVVL_ENABLE_UBSAN=ON'
         env:
-          CFLAGS: -fsanitize=thread
-          CXXFLAGS: -fsanitize=thread
-          LDFLAGS: -fsanitize=thread
           CMAKE_C_COMPILER_LAUNCHER: ccache
           CMAKE_CXX_COMPILER_LAUNCHER: ccache
-      # Thread Sanitize will take about 9x longer to run than Address Sanitize.
-      # The main reason we have Max Core and Min Core is to catch issues with Vulkan 1.x vs Vulkan 1.y version issues.
-      # In effort to reduce the bottle neck time in testing, skipping these for Thread Sanitize.
       - name: Test Max Profile
-        run: python scripts/tests_vksc.py --test --tsan
+        run: python scripts/tests_vksc.py --test
         env:
           VKSC_DEVSIM_PROFILE_FILE: ${{ github.workspace }}/tests/vulkansc/device_profiles/max_profile.json
 
+  # Ensure we can build on an older Ubuntu distro with an older version of CMake.
+  linux_back_compat:
+    needs: check_vvl
+    runs-on: ubuntu-22.04
+    name: "Ubuntu Backcompat"
+    steps:
+      - uses: actions/checkout@v4
+      - name: Test Minimum CMake Version
+        uses: lukka/get-cmake@latest
+        with:
+          cmakeVersion: 3.22.1
+      - uses: hendrikmuhs/[email protected]
+        with:
+          key: linux_back_compat
+      - run: sudo apt-get -qq update && sudo apt-get install -y libwayland-dev xorg-dev
+      - run: cmake -S . -B build/ -D UPDATE_DEPS=ON -D CMAKE_BUILD_TYPE=Debug
+        env:
+          CMAKE_C_COMPILER_LAUNCHER: ccache
+          CMAKE_CXX_COMPILER_LAUNCHER: ccache
+          # Linker warnings as errors
+          LDFLAGS: -Wl,--fatal-warnings
+      - run: cmake --build build
+      - run: cmake --install build --prefix /tmp
+
+
   windows:
     needs: check_vvl
     runs-on: windows-2022
@@ -167,14 +189,13 @@ jobs:
         uses: actions/cache@v4
         with:
           path: |
-            build-ci/external/glslang/build/install
-            build-ci/external/googltest/build/install
-            build-ci/external/mimalloc/build/install
-            build-ci/external/robin-hood-hashing/build/install
-            build-ci/external/SPIRV-Headers/build/install
-            build-ci/external/SPIRV-Tools/build/install
-            build-ci/external/Vulkan-Headers/build/install
-            build-ci/external/Vulkan-Utility-Libraries/build/install
+            ${{ github.workspace }}/external/glslang/build/install
+            ${{ github.workspace }}/external/googltest/build/install
+            ${{ github.workspace }}/external/mimalloc/build/install
+            ${{ github.workspace }}/external/SPIRV-Headers/build/install
+            ${{ github.workspace }}/external/SPIRV-Tools/build/install
+            ${{ github.workspace }}/external/Vulkan-Headers/build/install
+            ${{ github.workspace }}/external/Vulkan-Utility-Libraries/build/install
           key: windows-dependencies-${{ matrix.arch }}-${{ hashfiles('scripts/known_good.json') }}
       - name: Build
         run: python3 scripts/tests_vksc.py --build --config debug --cmake='-DUPDATE_DEPS_SKIP_EXISTING_INSTALL=ON'
@@ -203,7 +224,6 @@ jobs:
       - uses: actions/setup-python@v5
         with:
           python-version: '3.10'
-      - uses: lukka/get-cmake@latest
       - run: |
           cmake -S. -B build \
           -D BUILD_WERROR=ON \