build: Downstream Vulkan-ValidationLayers 1.3.302

Author: MathiasMagnus

BUILD.gn

@@ -108,6 +108,7 @@ vvl_sources = [
   "layers/core_checks/cc_descriptor.cpp",
   "layers/core_checks/cc_device.cpp",
   "layers/core_checks/cc_device_memory.cpp",
+  "layers/core_checks/cc_device_generated_commands.cpp",
   "layers/core_checks/cc_drawdispatch.cpp",
   "layers/core_checks/cc_external_object.cpp",
   "layers/core_checks/cc_image.cpp",
@@ -125,7 +126,10 @@ vvl_sources = [
   "layers/core_checks/cc_spirv.cpp",
   "layers/core_checks/cc_state_tracker.cpp",
   "layers/core_checks/cc_state_tracker.h",
+  "layers/core_checks/cc_submit.cpp",
+  "layers/core_checks/cc_submit.h",
   "layers/core_checks/cc_synchronization.cpp",
+  "layers/core_checks/cc_synchronization.h",
   "layers/core_checks/cc_video.cpp",
   "layers/core_checks/cc_vuid_maps.cpp",
   "layers/core_checks/cc_vuid_maps.h",
@@ -142,6 +146,9 @@ vvl_sources = [
   "layers/error_message/logging.cpp",
   "layers/error_message/logging.h",
   "layers/error_message/record_object.h",
+  "layers/error_message/log_message_type.h",
+  "layers/error_message/spirv_logging.cpp",
+  "layers/error_message/spirv_logging.h",
   "layers/external/inplace_function.h",
   "layers/external/vma/vk_mem_alloc.h",
   "layers/external/vma/vma.cpp",
@@ -157,10 +164,7 @@ vvl_sources = [
   "layers/gpu/cmd_validation/gpuav_draw.h",
   "layers/gpu/cmd_validation/gpuav_trace_rays.cpp",
   "layers/gpu/cmd_validation/gpuav_trace_rays.h",
-  "layers/gpu/core/gpu_settings.h",
-  "layers/gpu/core/gpu_shader_cache_hash.h",
-  "layers/gpu/core/gpu_state_tracker.cpp",
-  "layers/gpu/core/gpu_state_tracker.h",
+  "layers/gpu/core/gpuav_settings.h",
   "layers/gpu/core/gpuav.h",
   "layers/gpu/core/gpuav_constants.h",
   "layers/gpu/core/gpuav_record.cpp",
@@ -175,30 +179,33 @@ vvl_sources = [
   "layers/gpu/descriptor_validation/gpuav_image_layout.h",
   "layers/gpu/error_message/gpuav_vuids.cpp",
   "layers/gpu/error_message/gpuav_vuids.h",
-  "layers/gpu/instrumentation/gpu_shader_instrumentor.cpp",
-  "layers/gpu/instrumentation/gpu_shader_instrumentor.h",
+  "layers/gpu/instrumentation/gpuav_shader_instrumentor.cpp",
+  "layers/gpu/instrumentation/gpuav_shader_instrumentor.h",
   "layers/gpu/instrumentation/gpuav_instrumentation.cpp",
   "layers/gpu/instrumentation/gpuav_instrumentation.h",
-  "layers/gpu/resources/gpu_resources.cpp",
-  "layers/gpu/resources/gpu_resources.h",
-  "layers/gpu/resources/gpu_shader_resources.h",
+  "layers/gpu/resources/gpuav_resources.cpp",
+  "layers/gpu/resources/gpuav_resources.h",
+  "layers/gpu/resources/gpuav_shader_resources.h",
   "layers/gpu/resources/gpuav_subclasses.cpp",
   "layers/gpu/resources/gpuav_subclasses.h",
-  "layers/gpu/shaders/gpu_error_codes.h",
-  "layers/gpu/shaders/gpu_error_header.h",
-  "layers/gpu/shaders/gpu_shaders_constants.h",
-  "layers/gpu/spirv/bindless_descriptor_pass.cpp",
-  "layers/gpu/spirv/bindless_descriptor_pass.h",
-  "layers/gpu/spirv/non_bindless_oob_buffer_pass.cpp",
-  "layers/gpu/spirv/non_bindless_oob_buffer_pass.h",
-  "layers/gpu/spirv/non_bindless_oob_texel_buffer_pass.cpp",
-  "layers/gpu/spirv/non_bindless_oob_texel_buffer_pass.h",
+  "layers/gpu/shaders/gpuav_error_codes.h",
+  "layers/gpu/shaders/gpuav_error_header.h",
+  "layers/gpu/shaders/gpuav_shaders_constants.h",
+  "layers/gpu/spirv/descriptor_indexing_oob_pass.cpp",
+  "layers/gpu/spirv/descriptor_indexing_oob_pass.h",
+  "layers/gpu/spirv/descriptor_class_general_buffer_pass.cpp",
+  "layers/gpu/spirv/descriptor_class_general_buffer_pass.h",
+  "layers/gpu/spirv/descriptor_class_texel_buffer_pass.cpp",
+  "layers/gpu/spirv/descriptor_class_texel_buffer_pass.h",
   "layers/gpu/spirv/buffer_device_address_pass.cpp",
   "layers/gpu/spirv/buffer_device_address_pass.h",
+  "layers/gpu/spirv/post_process_descriptor_indexing.cpp",
+  "layers/gpu/spirv/post_process_descriptor_indexing.h",
   "layers/gpu/spirv/function_basic_block.cpp",
   "layers/gpu/spirv/function_basic_block.h",
   "layers/gpu/spirv/instruction.cpp",
   "layers/gpu/spirv/instruction.h",
+  "layers/gpu/spirv/interface.h",
   "layers/gpu/spirv/link.h",
   "layers/gpu/spirv/module.cpp",
   "layers/gpu/spirv/module.h",
@@ -224,6 +231,8 @@ vvl_sources = [
   "layers/state_tracker/cmd_buffer_state.h",
   "layers/state_tracker/descriptor_sets.cpp",
   "layers/state_tracker/descriptor_sets.h",
+  "layers/state_tracker/device_generated_commands_state.cpp",
+  "layers/state_tracker/device_generated_commands_state.h",
   "layers/state_tracker/device_memory_state.cpp",
   "layers/state_tracker/device_memory_state.h",
   "layers/state_tracker/device_state.cpp",
@@ -269,6 +278,7 @@ vvl_sources = [
   "layers/stateless/sl_cmd_buffer.cpp",
   "layers/stateless/sl_cmd_buffer_dynamic.cpp",
   "layers/stateless/sl_descriptor.cpp",
+  "layers/stateless/sl_device_generated_commands.cpp",
   "layers/stateless/sl_device_memory.cpp",
   "layers/stateless/sl_external_object.cpp",
   "layers/stateless/sl_framebuffer.cpp",
@@ -297,6 +307,8 @@ vvl_sources = [
   "layers/sync/sync_op.h",
   "layers/sync/sync_renderpass.cpp",
   "layers/sync/sync_renderpass.h",
+  "layers/sync/sync_reporting.cpp",
+  "layers/sync/sync_reporting.h",
   "layers/sync/sync_settings.h",
   "layers/sync/sync_stats.cpp",
   "layers/sync/sync_stats.h",
@@ -355,17 +367,20 @@ vvl_sources = [
   "layers/vulkan/generated/error_location_helper.h",
   "layers/vulkan/generated/feature_requirements_helper.cpp",
   "layers/vulkan/generated/feature_requirements_helper.h",
-  "layers/vulkan/generated/gpu_av_shader_hash.h",
-  "layers/vulkan/generated/instrumentation_bindless_descriptor_comp.cpp",
-  "layers/vulkan/generated/instrumentation_bindless_descriptor_comp.h",
-  "layers/vulkan/generated/instrumentation_non_bindless_oob_buffer_comp.cpp",
-  "layers/vulkan/generated/instrumentation_non_bindless_oob_buffer_comp.h",
-  "layers/vulkan/generated/instrumentation_non_bindless_oob_texel_buffer_comp.cpp",
-  "layers/vulkan/generated/instrumentation_non_bindless_oob_texel_buffer_comp.h",
+  "layers/vulkan/generated/instrumentation_descriptor_indexing_oob_bindless_comp.cpp",
+  "layers/vulkan/generated/instrumentation_descriptor_indexing_oob_bindless_comp.h",
+  "layers/vulkan/generated/instrumentation_descriptor_indexing_oob_non_bindless_comp.cpp",
+  "layers/vulkan/generated/instrumentation_descriptor_indexing_oob_non_bindless_comp.h",
+  "layers/vulkan/generated/instrumentation_descriptor_class_general_buffer_comp.cpp",
+  "layers/vulkan/generated/instrumentation_descriptor_class_general_buffer_comp.h",
+  "layers/vulkan/generated/instrumentation_descriptor_class_texel_buffer_comp.cpp",
+  "layers/vulkan/generated/instrumentation_descriptor_class_texel_buffer_comp.h",
   "layers/vulkan/generated/instrumentation_buffer_device_address_comp.cpp",
   "layers/vulkan/generated/instrumentation_buffer_device_address_comp.h",
   "layers/vulkan/generated/instrumentation_ray_query_comp.cpp",
   "layers/vulkan/generated/instrumentation_ray_query_comp.h",
+  "layers/vulkan/generated/instrumentation_post_process_descriptor_index_comp.cpp",
+  "layers/vulkan/generated/instrumentation_post_process_descriptor_index_comp.h",
   "layers/vulkan/generated/layer_chassis_dispatch.cpp",
   "layers/vulkan/generated/layer_chassis_dispatch.h",
   "layers/vulkan/generated/object_tracker.cpp",

CMakeLists.txt

@@ -207,4 +207,10 @@ option(BUILD_TESTS "Build the tests")
 if(BUILD_TESTS)
     enable_testing()
     add_subdirectory(tests)
+    # Set tests as Visual Studio startup project
+    if(VULKANSC)
+        set_property(DIRECTORY PROPERTY VS_STARTUP_PROJECT vksc_layer_validation_tests)
+    else()
+        set_property(DIRECTORY PROPERTY VS_STARTUP_PROJECT vk_layer_validation_tests)
+    endif()
 endif()

README.md

@@ -16,6 +16,10 @@ For those who don't want to build from source, there are few ways to get working
 - For Android, each SDK tag will have binaries to download (example: [vulkan-sdk-1.3.280.0 tag](https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases/tag/vulkan-sdk-1.3.280.0))
 - Every change applied to the main branch runs through GitHub action and will [produce artifacts](https://github.com/KhronosGroup/Vulkan-ValidationLayers/actions?query=branch%3Amain) of the latest commit.
 
+## Adjusting settings
+
+See [settings documentation](./docs/settings.md).
+
 ## Community Assistance
 
 Before submitting an issue to the validation layers or reaching out to the developers it may be prudent to reach out to the community first.

docs/creating_tests.md

@@ -180,7 +180,7 @@ m_errorMonitor->VerifyFound();
 ```cpp
 m_errorMonitor->SetDesiredError("VUID-VkDeviceGroupRenderPassBeginInfo-deviceMask-00905");
 m_errorMonitor->SetDesiredError("VUID-VkDeviceGroupRenderPassBeginInfo-deviceMask-00907");
-vk::CmdBeginRenderPass(m_commandBuffer->handle(), &m_renderPassBeginInfo, VK_SUBPASS_CONTENTS_INLINE);
+vk::CmdBeginRenderPass(m_command_buffer.handle(), &m_renderPassBeginInfo, VK_SUBPASS_CONTENTS_INLINE);
 m_errorMonitor->VerifyFound();
 ```
 
@@ -189,7 +189,7 @@ m_errorMonitor->VerifyFound();
 ```cpp
 const char* vuid = IsExtensionsEnabled(VK_KHR_SAMPLER_YCBCR_CONVERSION_EXTENSION_NAME) ? "VUID-vkCmdCopyImage-dstImage-01733" : "VUID-vkCmdCopyImage-dstImage-01733";
 m_errorMonitor->SetDesiredError(vuid);
-m_commandBuffer->CopyImage(image_2.image(), VK_IMAGE_LAYOUT_GENERAL, image_1.image(), VK_IMAGE_LAYOUT_GENERAL, 1, &copy_region);
+m_command_buffer.CopyImage(image_2.image(), VK_IMAGE_LAYOUT_GENERAL, image_1.image(), VK_IMAGE_LAYOUT_GENERAL, 1, &copy_region);
 m_errorMonitor->VerifyFound();
 ```
 

docs/debug_printf.md

@@ -25,9 +25,13 @@ The Debug Printf settings are managed by configuring the Validation Layer. These
 
 Debug Printf settings can also be managed using the [Vulkan Configurator](https://vulkan.lunarg.com/doc/sdk/latest/windows/vkconfig.html) included with the Vulkan SDK.
 
+For those who "just need to quick use it" there is also a `set VK_LAYER_PRINTF_ONLY_PRESET=1` environment variable that will turn on DebugPrintf and turn off all of the other validation logic.
+
 ### Settings
 
 > All settings are found in Vulkan Configurator (`VkConfig`)
+>
+> Even if you use `VK_LAYER_PRINTF_ONLY_PRESET` you need to set those settings yourself as desired
 
 There are currently 3 environment variables that are used for settings in Debug Printf
 
@@ -46,7 +50,7 @@ There are currently 3 environment variables that are used for settings in Debug
 To use Debug Printf in GLSL shaders, you need to enable the GL_EXT_debug_printf extension.
 Then add debugPrintfEXT calls at the locations in your shader where you want to print
 messages and/or values
-Here is a very simple example:
+Here is a very simple example ([Try Online](https://godbolt.org/z/MnYGj8azM)):
 ```
 #version 450
 #extension GL_EXT_debug_printf : enable
@@ -64,7 +68,7 @@ in a vertex shader and a triangle was drawn, it would be printed 3 times.
 
 ## Using Debug Printf in HLSL Shaders
 
-In HLSL, debug printf can be invoked as follows:
+In HLSL, debug printf can be invoked as follows ([Try Online](https://godbolt.org/z/3ThznsdK8)):
 ```
 void main() {
     float myfloat = 3.1415;
@@ -182,8 +186,6 @@ Would print **"Here's a vector of floats 1.20, 2.20, 3.20, 4.20"**
 Would print **"Unsigned long as decimal 2305843009213693953 and as hex 0x2000000000000001"**
 
 ### Limitations
-* Debug Printf cannot be used at the same time as GPU Assisted Validation.
-  * https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8192
 * Debug Printf consumes a descriptor set. If your application uses every last
 descriptor set on the GPU, Debug Printf will not work.
   * Suggest using `VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_RESERVE_BINDING_SLOT_EXT`
@@ -193,8 +195,7 @@ buffer size.
   * Can be controlled with `VK_LAYER_PRINTF_BUFFER_SIZE`
 * Validation Layers version: `1.2.135.0` or later is required
 * Vulkan API version 1.1 or greater is required
-* VkPhysicalDevice features: `fragmentStoresAndAtomics` and `vertexPipelineStoresAndAtomics`
-are required
+* When using Validation Layers, the `fragmentStoresAndAtomics`, `vertexPipelineStoresAndAtomics`, and `timelineSemaphore` features are required
 * The `VK_KHR_shader_non_semantic_info` extension must be supported and enabled
   * If using the Validation Layers, we attempt to strip it out to allow wider range of users to still use Debug Printf
 * RenderDoc release 1.14 or later

docs/generated_code.md

@@ -7,6 +7,10 @@ values when the Vulkan Headers or SPIR-V Grammer is updated.
 - [Adding and Editing code generation](#adding-and-editing-code-generation)
 - [How it works](#how-it-works)
 
+# Dependency
+
+`pyparsing` is required, so if it is not installed, you will need to call `pip install pyparsing`
+
 # How to generate the code
 
 - Linux: