[Continuous Profile] profiler.frame.type attribute for all locations (open-telemetry#3919)

Author: Kielek

test/IntegrationTests/ContinuousProfilerTests.cs

@@ -4,6 +4,7 @@
 #if NET
 
 using IntegrationTests.Helpers;
+using OpenTelemetry.Proto.Collector.Profiles.V1Development;
 using OpenTelemetry.Proto.Profiles.V1Development;
 using Xunit.Abstractions;
 
@@ -43,17 +44,39 @@ public void ExportThreadSamples()
         SetExporter(collector);
         SetEnvironmentVariable("OTEL_DOTNET_AUTO_PLUGINS", "TestApplication.ContinuousProfiler.ThreadPlugin, TestApplication.ContinuousProfiler, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null");
         SetEnvironmentVariable("OTEL_DOTNET_AUTO_TRACES_ADDITIONAL_SOURCES", "TestApplication.ContinuousProfiler");
-        RunTestApplication();
-
         var expectedStackTrace = string.Join("\n", CreateExpectedStackTrace());
 
+        collector.ExpectCollected(AllLocationReferencesProfileFrameTypeAttribute, "All location should contain reference to profile.frame.type attribute");
         collector.Expect(profileData => profileData.ResourceProfiles.Any(resourceProfiles => resourceProfiles.ScopeProfiles.Any(scopeProfile => scopeProfile.Profiles.Any(profile => ContainStackTraceForClassHierarchy(profile, expectedStackTrace) && ContainAttributes(profile, "cpu")))));
         collector.ResourceExpector.Expect("todo.resource.detector.key", "todo.resource.detector.value");
 
+        RunTestApplication();
+
+        collector.AssertCollected();
         collector.AssertExpectations();
         collector.ResourceExpector.AssertExpectations();
     }
 
+    private static bool AllLocationReferencesProfileFrameTypeAttribute(ICollection<ExportProfilesServiceRequest> c)
+    {
+        var profiles = c.SelectMany(r => r.ResourceProfiles)
+            .SelectMany(rp => rp.ScopeProfiles)
+            .SelectMany(sp => sp.Profiles).ToList();
+
+        foreach (var profile in profiles)
+        {
+            var attributeTable = profile.AttributeTable;
+
+            var attributeIndices = profiles.SelectMany(p => p.LocationTable).Select(l => l.AttributeIndices.Single());
+            if (!attributeIndices.All(index => attributeTable[index] is { Key: "profile.frame.type" }))
+            {
+                return false;
+            }
+        }
+
+        return true;
+    }
+
     private static bool ContainAttributes(Profile profileContainer, string profilingDataType)
     {
         return profileContainer.AttributeTable.Any(x => x.Key == "todo.profiling.data.type" && x.Value.StringValue == profilingDataType);

test/IntegrationTests/Helpers/MockProfilesCollector.cs

@@ -157,8 +157,8 @@ private static void FailExpectations(
     private static void FailCollectedExpectation(string? collectedExpectationDescription, ExportProfilesServiceRequest[] collectedExportProfilesServiceRequests)
     {
         var message = new StringBuilder();
-        message.AppendLine($"Collected logs expectation failed: {collectedExpectationDescription}");
-        message.AppendLine("Collected logs:");
+        message.AppendLine($"Collected profiles expectation failed: {collectedExpectationDescription}");
+        message.AppendLine("Collected profiles:");
         foreach (var logRecord in collectedExportProfilesServiceRequests)
         {
             message.AppendLine($"    \"{logRecord}\"");

test/test-applications/integrations/TestApplication.ContinuousProfiler/Exporter/ExtendedPprofBuilder.cs

@@ -25,9 +25,11 @@ public ExtendedPprofBuilder(string profilingDataType, long timestampNanoseconds)
         };
         var stringCache = new StringCache(Profile);
         var functionCache = new FunctionCache(Profile, stringCache);
-        _locationCache = new LocationCache(Profile, functionCache);
         _linkCache = new LinkCache(Profile);
         _attributeCache = new AttributeCache(Profile);
+        var profileFrameTypeAttributeId = _attributeCache.GetOrAdd("profile.frame.type", value => value.StringValue = "dotnet");
+
+        _locationCache = new LocationCache(Profile, functionCache, profileFrameTypeAttributeId);
 
         var profilingDataTypeAttributeId = _attributeCache.GetOrAdd("todo.profiling.data.type", value => value.StringValue = profilingDataType);
         Profile.AttributeIndices.Add(profilingDataTypeAttributeId);
@@ -119,17 +121,20 @@ private class LocationCache
     {
         private readonly Profile _profile;
         private readonly FunctionCache _functionCache;
+        private readonly int _profileFrameTypeAttributeId;
         private int _index;
 
-        public LocationCache(Profile profile, FunctionCache functionCache)
+        public LocationCache(Profile profile, FunctionCache functionCache, int profileFrameTypeAttributeId)
         {
             _profile = profile;
             _functionCache = functionCache;
+            _profileFrameTypeAttributeId = profileFrameTypeAttributeId;
         }
 
         public int Add(string function)
         {
             var location = new Location();
+            location.AttributeIndices.Add(_profileFrameTypeAttributeId);
             location.Line.Add(new Line { FunctionIndex = _functionCache.GetOrAdd(function), Line_ = 0, Column = 0 }); // for now, we don't support line nor column number
 
             _profile.LocationTable.Add(location);