Merge pull request ghostunnel#665 from ghostunnel/claude/remove-dead-code-2XK7F

Remove dead code from certloader/internal/test

Author: csstaub

certloader/internal/test/pem.go

@@ -1,7 +1,6 @@
 package spiffetest
 
 import (
-	"crypto"
 	"crypto/x509"
 	"encoding/pem"
 	"errors"
@@ -31,45 +30,6 @@ func ParseCertificates(certsBytes []byte) ([]*x509.Certificate, error) {
 	return certs, nil
 }
 
-func ParsePrivateKey(keyBytes []byte) (crypto.PrivateKey, error) {
-	objects, err := parseBlocks(keyBytes, keyType)
-	if err != nil {
-		return nil, err
-	}
-	if len(objects) == 0 {
-		return nil, nil
-	}
-
-	privateKey, ok := objects[0].(crypto.PrivateKey)
-	if !ok {
-		return nil, fmt.Errorf("expected crypto.PrivateKey; got %T", objects[0])
-	}
-	return privateKey, nil
-}
-
-func EncodePKCS8PrivateKey(privateKey any) ([]byte, error) {
-	keyBytes, err := x509.MarshalPKCS8PrivateKey(privateKey)
-	if err != nil {
-		return nil, err
-	}
-
-	return pem.EncodeToMemory(&pem.Block{
-		Type:  keyType,
-		Bytes: keyBytes,
-	}), nil
-}
-
-func EncodeCertificates(certificates []*x509.Certificate) []byte {
-	pemBytes := []byte{}
-	for _, cert := range certificates {
-		pemBytes = append(pemBytes, pem.EncodeToMemory(&pem.Block{
-			Type:  certType,
-			Bytes: cert.Raw,
-		})...)
-	}
-	return pemBytes
-}
-
 func parseBlocks(blocksBytes []byte, expectedType string) ([]any, error) {
 	objects := []any{}
 	var foundBlocks = false

certloader/internal/test/util.go

@@ -13,37 +13,6 @@ func NewCertPool(certs []*x509.Certificate) *x509.CertPool {
 	return pool
 }
 
-// CopyX509Authorities copies a slice of X.509 certificates to a new slice.
-func CopyX509Authorities(x509Authorities []*x509.Certificate) []*x509.Certificate {
-	copiedX509Authorities := make([]*x509.Certificate, len(x509Authorities))
-	copy(copiedX509Authorities, x509Authorities)
-
-	return copiedX509Authorities
-}
-
-// CertsEqual returns true if the slices of X.509 certificates are equal.
-func CertsEqual(a, b []*x509.Certificate) bool {
-	if len(a) != len(b) {
-		return false
-	}
-
-	for i, cert := range a {
-		if !cert.Equal(b[i]) {
-			return false
-		}
-	}
-
-	return true
-}
-
-func RawCertsFromCerts(certs []*x509.Certificate) [][]byte {
-	rawCerts := make([][]byte, 0, len(certs))
-	for _, cert := range certs {
-		rawCerts = append(rawCerts, cert.Raw)
-	}
-	return rawCerts
-}
-
 func ConcatRawCertsFromCerts(certs []*x509.Certificate) []byte {
 	var rawCerts []byte
 	for _, cert := range certs {