[pull] master from ghostunnel:master#37
Merged
Merged
Conversation
Add apple:codesign and apple:notarize mage targets for signing and notarizing macOS binaries. Codesign uses the macOS codesign tool with hardened runtime enabled. Notarize submits to Apple's notary service via xcrun notarytool with App Store Connect API key auth. For CI, CODESIGN_CERTIFICATE (base64 .p12) triggers temporary keychain creation with automatic cleanup. NOTARIZE_KEY (base64 .p8) is written to a temp file for notarytool. Sensitive security commands use runSilent to suppress argument echoing in CI logs. Add codesign and notarize steps to the Darwin release workflow. Change Docker tagging so "latest" is only applied on release tag pushes (e.g. v1.9.0), not on master branch pushes. Master pushes now produce "master" tagged images instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
More unit tests to improve test coverage
Add macOS codesigning, notarization, and Docker tag improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )