Skip to content

Commit 6d1bbe0

Browse files
committed
dnsdist: Consistently handle slow protobuf messages in our tests
It was not an issue before, but GH actions runners are so bad these days that we are now encountering these errors quite often. In any case we should have been more consistent to begin with. Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
1 parent 407e72c commit 6d1bbe0

2 files changed

Lines changed: 40 additions & 88 deletions

File tree

regression-tests.dnsdist/test_OpenTelemetryTracing.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,8 @@ def sendQueryAndGetProtobuf(
6666
self.assertTrue(receivedResponse)
6767
self.assertEqual(response, receivedResponse)
6868

69-
if self._protobufQueue.empty():
70-
# let the protobuf messages the time to get there
71-
time.sleep(1)
72-
7369
# check the protobuf message corresponding to the UDP query
74-
return self.getFirstProtobufMessage()
70+
return self.getFirstProtobufMessage(timeout=1)
7571

7672
def checkOTData(
7773
self,

0 commit comments

Comments
 (0)