fix: removing stream selections (webtorrent#2952)

Author: ThaUnknown

lib/selections.js

@@ -27,18 +27,16 @@ export class Selections {
   remove (item) {
     for (let i = 0; i < this._items.length; i++) {
       const existing = this._items[i]
+      // we only remove stream selections when the `isStreamSelection` flag match, cast to boolean using !
+      if (!existing.isStreamSelection !== !item.isStreamSelection) continue
+
       if (existing.isStreamSelection) {
-        if (item.isStreamSelection) {
-          // If both are stream selections and they match, then we remove the first matching item, then we break the loop
-          if (existing.from === item.from && existing.to === item.to) {
-            this._items.splice(i, 1)
-            // for stream selections, we only remove one item at a time
-            // ergo we break the loop after removing the first matching item
-            break
-          }
-        } else {
-          // we only remove stream selections when the `isStreamSelection` flag is true and they match
-          continue
+        // If both are stream selections and they match, then we remove the first matching item, then we break the loop
+        if (existing.from === item.from && existing.to === item.to) {
+          this._items.splice(i, 1)
+          // for stream selections, we only remove one item at a time
+          // ergo we break the loop after removing the first matching item
+          break
         }
       } else {
         if (isLowerIntersecting(item, existing)) {