Merge pull request #119 from patrickhlauke/patrickhlauke-fix

KittyGiraudel · web-flow · commit b9c68aa1d457 · 2020-10-11T21:28:34.000+02:00
Reintroduce removal of `aria-hidden`, bump to 5.4.1
diff --git a/a11y-dialog.js b/a11y-dialog.js
@@ -133,7 +133,8 @@
       this.dialog.showModal(event instanceof Event ? void 0 : event);
     } else {
       this.dialog.setAttribute('open', '');
-
+      this.container.removeAttribute('aria-hidden');
+      
       // Iterate over the targets to disable them by setting their `aria-hidden`
       // attribute to `true` and, if present, storing the current value of `aria-hidden`
       this._targets.forEach(function(target) {
diff --git a/a11y-dialog.min.js b/a11y-dialog.min.js
diff --git a/example/main.js b/example/main.js
@@ -133,7 +133,8 @@
       this.dialog.showModal(event instanceof Event ? void 0 : event);
     } else {
       this.dialog.setAttribute('open', '');
-
+      this.container.removeAttribute('aria-hidden');
+      
       // Iterate over the targets to disable them by setting their `aria-hidden`
       // attribute to `true` and, if present, storing the current value of `aria-hidden`
       this._targets.forEach(function(target) {
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "a11y-dialog",
-  "version": "5.4.0",
+  "version": "5.4.1",
   "description": "A tiny script to make dialog windows accessible to assistive technology users.",
   "homepage": "https://github.com/edenspiekermann/a11y-dialog",
   "license": "MIT",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "a11y-dialog",`
`3`		`- "version": "5.4.0",`
	`3`	`+ "version": "5.4.1",`
`4`	`4`	`"description": "A tiny script to make dialog windows accessible to assistive technology users.",`
`5`	`5`	`"homepage": "https://github.com/edenspiekermann/a11y-dialog",`
`6`	`6`	`"license": "MIT",`