Remove label filter propagation (#3724)

CDash currently supports the ability to propagate label filters from the
index page to viewTest.php. This functionality is fundamentally broken
in all but the most simple case, since extracting only the label filters
is not logically equivalent to the full original filters. This PR
removes the feature entirely. In the future, there's an opportunity to
add something which fills roughly the same niche: allowing users to
select a subset of subprojects to display, which can be propagated to
other pages automatically.

Author: williamjallen

app/Models/Project.php

@@ -42,7 +42,6 @@
  * @property int $uploadquota Maximum sum of uploaded file sizes (in bytes)
  * @property int $uploadquotagb Maximum sum of uploaded file sizes (in GiB)
  * @property bool $showcoveragecode
- * @property bool $sharelabelfilters
  * @property bool $authenticatesubmissions
  * @property ?string $ldapfilter
  * @property ?string $banner
@@ -90,7 +89,6 @@ class Project extends Model
         'uploadquota',
         'uploadquotagb',
         'showcoveragecode',
-        'sharelabelfilters',
         'authenticatesubmissions',
         'ldapfilter',
         'banner',
@@ -109,7 +107,6 @@ class Project extends Model
         'displaylabels' => 'boolean',
         'coveragethreshold' => 'integer',
         'showcoveragecode' => 'boolean',
-        'sharelabelfilters' => 'boolean',
         'authenticatesubmissions' => 'boolean',
     ];
 

app/cdash/app/Controller/Api/Index.php

@@ -1350,7 +1350,7 @@ public function checkForSubProjectFilters(): void
             }
         }
         unset($filters);
-        if ($filter_on_labels && $this->project->ShareLabelFilters) {
+        if ($filter_on_labels) {
             $this->shareLabelFilters = true;
             $this->labelIds = get_label_ids_from_filterdata($this->filterdata);
         }

app/cdash/app/Model/Project.php

@@ -69,7 +69,6 @@ class Project
     public $EmailMaxItems = 5;
     public $EmailMaxChars = 255;
     public $DisplayLabels = 0;
-    public $ShareLabelFilters = 0;
     public $AuthenticateSubmissions = 0;
     public $ShowCoverageCode = 0;
     public $AutoremoveTimeframe = 0;
@@ -126,7 +125,6 @@ public function Save(): bool
             'emailbrokensubmission' => filter_var($this->EmailBrokenSubmission, FILTER_VALIDATE_BOOLEAN),
             'emailredundantfailures' => filter_var($this->EmailRedundantFailures, FILTER_VALIDATE_BOOLEAN),
             'displaylabels' => filter_var($this->DisplayLabels, FILTER_VALIDATE_BOOLEAN),
-            'sharelabelfilters' => filter_var($this->ShareLabelFilters, FILTER_VALIDATE_BOOLEAN),
             'authenticatesubmissions' => filter_var($this->AuthenticateSubmissions, FILTER_VALIDATE_BOOLEAN),
             'showcoveragecode' => filter_var($this->ShowCoverageCode, FILTER_VALIDATE_BOOLEAN),
             'autoremovetimeframe' => (int) $this->AutoremoveTimeframe,
@@ -206,7 +204,6 @@ public function Fill(): void
             $this->EmailBrokenSubmission = (int) $project->emailbrokensubmission;
             $this->EmailRedundantFailures = (int) $project->emailredundantfailures;
             $this->DisplayLabels = $project->displaylabels;
-            $this->ShareLabelFilters = $project->sharelabelfilters;
             $this->AuthenticateSubmissions = $project->authenticatesubmissions;
             $this->ShowCoverageCode = $project->showcoveragecode;
             $this->AutoremoveTimeframe = $project->autoremovetimeframe;

app/cdash/public/api/v1/index.php

@@ -236,7 +236,6 @@
 $response['filterurl'] = get_filterurl();
 
 $controller->checkForSubProjectFilters();
-$response['sharelabelfilters'] = $controller->shareLabelFilters;
 $response['testfilters'] = $controller->subProjectTestFilters;
 
 $build_data = $controller->getDailyBuilds();

app/cdash/tests/test_actualtrilinossubmission.php

@@ -25,7 +25,7 @@ public function createProjectWithName($project)
             'EmailBrokenSubmission' => '1',
             'DisplayLabels' => '1',
             'NightlyTime' => '21:00:00 America/New_York',
-            'ShareLabelFilters' => '1'];
+        ];
         return $this->createProject($settings);
     }
 

app/cdash/tests/test_filtertestlabels.php

@@ -28,10 +28,6 @@ public function testFilterLabels()
             return 1;
         }
 
-        // Turn this option on.
-        pdo_query("UPDATE project SET sharelabelfilters=TRUE
-                WHERE name='EmailProjectExample'");
-
         // Get the buildid that we just created so we can delete it later.
         $buildids = [];
         $buildid_results = pdo_query(
@@ -91,10 +87,6 @@ public function testFilterLabels()
         // Delete the build
         DatabaseCleanupUtils::removeBuild($buildid);
 
-        // Turn the option back off.
-        pdo_query("UPDATE project SET sharelabelfilters=FALSE
-                WHERE name='EmailProjectExample'");
-
         if (!$success) {
             $this->fail($error_msg);
             return 1;

database/migrations/2026_05_13_223707_drop_project_sharelabelfilters_column.php

@@ -0,0 +1,15 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Support\Facades\DB;
+
+return new class extends Migration {
+    public function up(): void
+    {
+        DB::statement('ALTER TABLE project DROP COLUMN sharelabelfilters');
+    }
+
+    public function down(): void
+    {
+    }
+};

graphql/schema.graphql

@@ -340,9 +340,6 @@ type Project {
   """
   showCoverageCode: Boolean! @rename(attribute: "showcoveragecode")
 
-  "Forward label filters from index.php to queryTests.php and viewTest.php."
-  shareLabelFilters: Boolean! @rename(attribute: "sharelabelfilters")
-
   "Custom text displayed at the top of a project's dashboard."
   banner: String
 
@@ -494,8 +491,6 @@ input UpdateProjectInput @validator {
 
   showCoverageCode: Boolean @rename(attribute: "showcoveragecode")
 
-  shareLabelFilters: Boolean @rename(attribute: "sharelabelfilters")
-
   banner: String
 }
 

phpstan-baseline.neon

@@ -9879,12 +9879,6 @@ parameters:
 			count: 1
 			path: app/cdash/app/Model/Project.php
 
-		-
-			rawMessage: Property CDash\Model\Project::$ShareLabelFilters has no type specified.
-			identifier: missingType.property
-			count: 1
-			path: app/cdash/app/Model/Project.php
-
 		-
 			rawMessage: Property CDash\Model\Project::$ShowCoverageCode has no type specified.
 			identifier: missingType.property
@@ -18924,7 +18918,7 @@ parameters:
 				04/01/2023
 			'''
 			identifier: function.deprecated
-			count: 3
+			count: 1
 			path: app/cdash/tests/test_filtertestlabels.php
 
 		-

resources/js/angular/controllers/index.js

@@ -220,13 +220,6 @@ export function IndexController($scope, $rootScope, $location, $http, $filter, $
       $scope.pageChanged($scope.cdash.buildgroups[i]);
     }
 
-    // Check for label filters
-    $scope.cdash.extrafilterurl = '';
-    if ($scope.cdash.sharelabelfilters) {
-      $scope.cdash.extrafilterurl = filters.getLabelString($scope.cdash.filterdata);
-      $scope.cdash.querytestfilters = $scope.cdash.extrafilterurl;
-    }
-
     // Read simple/advanced view cookie setting.
     var advanced_cookie = $.cookie('cdash_'+$scope.cdash.projectname+'_advancedview');
     var show_time_columns = 0;