Remove legacy viewTest.php page

This page has been completely replaced by `/builds/<id>/tests` and is now redundant.

Author: williamjallen

app/cdash/app/Model/Build.php

@@ -2239,7 +2239,7 @@ public function GetBuildErrorUrl(): string
 
     public function GetTestUrl(): string
     {
-        return url('/viewTest.php') . "?buildid={$this->Id}";
+        return url("/builds/{$this->Id}/tests");
     }
 
     public static function ConvertMissingToZero($value): int

app/cdash/tests/autoremovebuilds/CMakeLists.txt

@@ -5,7 +5,6 @@ set_property(TEST deletesubproject PROPERTY DEPENDS
   cypress/e2e/manage-overview
   cypress/e2e/manage-build-group
   cypress/e2e/manage-sub-project
-  cypress/e2e/view-test
   cypress/e2e/sort-index
   cypress/e2e/expected-build
   cypress/e2e/remove-build

phpstan-baseline.neon

@@ -23562,7 +23562,7 @@ parameters:
 		-
 			rawMessage: 'Part $buildid (array|string|null) of encapsed string cannot be cast to string.'
 			identifier: encapsedStringPart.nonString
-			count: 7
+			count: 8
 			path: routes/web.php
 
 		-

resources/js/angular/controllers/viewTest.js

@@ -57,9 +57,6 @@ CDash.controller('SubProjectController', ["$scope", "$rootScope", "$http", SubPr
 import { QueryTestsController } from "./controllers/queryTests";
 CDash.controller('QueryTestsController', ["$scope", "$rootScope", "$filter", "apiLoader", "filters", "multisort", QueryTestsController]);
 
-import { ViewTestController } from "./controllers/viewTest";
-CDash.controller('ViewTestController', ["$scope", "$rootScope", "$http", "$filter", "$q", "apiLoader", "multisort", "filters", ViewTestController]);
-
 import { OverviewController, linechart, bulletchart } from "./controllers/overview";
 CDash.controller('OverviewController', ["$scope", "$location", "anchors", "apiLoader", OverviewController]);
 CDash.directive('linechart', linechart);

resources/js/angular/legacy.js

@@ -86,7 +86,6 @@
           Add test measurements of type <span class="tw-font-mono">numeric/double</span> or <span class="tw-font-mono">text/string</span>. Any measurement added here will be displayed as an extra column on the following pages:
           <ul class="tw-list-circle tw-ml-4">
             <li><span class="tw-font-mono">queryTests.php</span></li>
-            <li><span class="tw-font-mono">viewTest.php</span></li>
             <li><span class="tw-font-mono">builds/&lt;id&gt;/tests</span></li>
           </ul>
         </li>