Skip to content

Commit c73044c

Browse files
Catch DivisionByZeroError on index.php (#2211)
Fixes #2204
1 parent c1ecdc7 commit c73044c

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

app/cdash/public/api/v1/index.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -412,11 +412,15 @@
412412
if ((int) $build_array['loctesteddiff'] > 0) {
413413
$loctesteddiff = (int) $build_array['loctesteddiff'];
414414
$locuntesteddiff = (int) $build_array['locuntesteddiff'];
415-
@$previouspercent =
416-
round(($loctested - $loctesteddiff) /
417-
($loctested - $loctesteddiff +
418-
$locuntested - $locuntesteddiff)
419-
* 100, 2);
415+
try {
416+
$previouspercent =
417+
round(($loctested - $loctesteddiff) /
418+
($loctested - $loctesteddiff +
419+
$locuntested - $locuntesteddiff)
420+
* 100, 2);
421+
} catch (\DivisionByZeroError $e) {
422+
$previouspercent = 0;
423+
}
420424
$percentdiff = round($percent - $previouspercent, 2);
421425
$coverage_response['percentagediff'] = $percentdiff;
422426
$coverage_response['locuntesteddiff'] = $locuntesteddiff;

0 commit comments

Comments
 (0)