Skip to content

Commit dcbc3a8

Browse files
committed
Change default builds per build group from 10 to 50
As discussed in #3715, a default of 10 builds per build group is insufficient for many projects. This low limit was set in an era when AngularJS rendering for the full page was extremely slow. This is no longer an issue, and it now makes sense to increase the default number of builds per build group. I have somewhat arbitrarily chosen 50 as the new default for all types of pagination across the site. I plan to make further improvements to this in the next ~6-12 months as part of the transition to Vue.
1 parent 6fe84d8 commit dcbc3a8

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

resources/js/angular/controllers/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export function IndexController($scope, $rootScope, $location, $http, $filter, $
128128
if(num_per_page_cookie) {
129129
$scope.cdash.buildgroups[i].pagination.numPerPage = parseInt(num_per_page_cookie);
130130
} else {
131-
$scope.cdash.buildgroups[i].pagination.numPerPage = 10;
131+
$scope.cdash.buildgroups[i].pagination.numPerPage = 50;
132132
}
133133

134134
// Setup sorting.

resources/js/angular/controllers/queryTests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export function QueryTestsController($scope, $rootScope, $filter, apiLoader, fil
1212
if(num_per_page_cookie) {
1313
$scope.pagination.numPerPage = parseInt(num_per_page_cookie);
1414
} else {
15-
$scope.pagination.numPerPage = 25;
15+
$scope.pagination.numPerPage = 50;
1616
}
1717

1818
// Hide filters by default.

resources/js/angular/controllers/testOverview.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export function TestOverviewController($scope, $rootScope, $filter, apiLoader, f
3535
if(num_per_page_cookie) {
3636
$scope.pagination.numPerPage = parseInt(num_per_page_cookie);
3737
} else {
38-
$scope.pagination.numPerPage = 10;
38+
$scope.pagination.numPerPage = 50;
3939
}
4040

4141
apiLoader.loadPageData($scope, 'api/v1/testOverview.php');

tests/cypress/e2e/query-tests.cy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,6 @@ describe('query tests', () => {
4949
// load the page and verify the expected number of tests.
5050
cy.visit(expected_url);
5151
cy.get('#numtests').should('contain', 'Query Tests: 126 matches');
52-
cy.get('#queryTestsTable').find('tbody').find('tr').should('have.length', 25);
52+
cy.get('#queryTestsTable').find('tbody').find('tr').should('have.length', 50);
5353
});
5454
});

0 commit comments

Comments
 (0)