Merge pull request #1094 from Kitware/misc_fixes

Various minor fixes to issues we discovered while updating our production instances

Author: zackgalbreath

app/cdash/app/Lib/Repository/GitHub.php

@@ -147,7 +147,12 @@ public function authenticate($required = true)
 
         $this->apiClient->authenticate($jwt, null, GitHubClient::AUTH_JWT);
 
-        $token = $this->apiClient->api('apps')->createInstallationToken($this->installationId);
+        try {
+            $token = $this->apiClient->api('apps')->createInstallationToken($this->installationId);
+        } catch (\Exception $e) {
+            \Log::error($e->getMessage());
+            return false;
+        }
         if ($token) {
             $this->apiClient->authenticate($token['token'], null, GitHubClient::AUTH_HTTP_TOKEN);
         }

app/cdash/include/repository.php

@@ -871,6 +871,9 @@ function generate_bugtracker_new_issue_link($build, $project)
         return false;
     }
     $msg_parts = generate_broken_build_message($emailtext, $build, $project);
+    if (!is_array($msg_parts)) {
+        return false;
+    }
     $title = $msg_parts['title'];
     $body = $msg_parts['body'];
 

app/cdash/xml_handlers/BazelJSON_handler.php

@@ -545,7 +545,12 @@ public function ParseLine($line)
                     }
 
                     $test_name = $json_array['id']['testResult']['label'];
-                    $test_time = $json_array['testResult']['testAttemptDurationMillis'] / 1000.0;
+                    $test_time = 0;
+                    if (array_key_exists('testAttemptDurationMillis', $json_array['testResult'])) {
+                        $test_time = $json_array['testResult']['testAttemptDurationMillis'] / 1000.0;
+                    } elseif (array_key_exists('testAttemptDurationMillis', $json_array['id']['testResult'])) {
+                        $test_time = $json_array['id']['testResult']['testAttemptDurationMillis'] / 1000.0;
+                    }
 
                     if (array_key_exists('shard', $json_array['id']['testResult'])) {
                         // This test uses shards, so a Test with this name