Skip to content

Commit eb9453e

Browse files
committed
Merge branch 'main' into multi-compare
2 parents a751ee8 + 01d3a0d commit eb9453e

13 files changed

Lines changed: 321 additions & 29 deletions

File tree

CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,24 @@
22

33
<!-- version list -->
44

5+
## v1.2.2 (2026-03-03)
6+
7+
### Bug Fixes
8+
9+
- **NERSC**: Improve jupyter/nersc usage
10+
([`cc7a7e5`](https://github.com/Kitware/E3SMQuickCompare/commit/cc7a7e55ec4d3b372822e1357c816735edd26176))
11+
12+
### Chores
13+
14+
- Cleanup pyproject
15+
([`2a3fa2e`](https://github.com/Kitware/E3SMQuickCompare/commit/2a3fa2e2531d0be5be2f12d93c5d84e5ccb2073f))
16+
17+
### Refactoring
18+
19+
- **name**: Rename compareview to quickcompare
20+
([`718824d`](https://github.com/Kitware/E3SMQuickCompare/commit/718824ddd986c2171366f695c8eed9505e888c56))
21+
22+
523
## v1.0.0 (2026-01-26)
624

725
- Initial Release

pyproject.toml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "e3sm-compareview"
3-
version = "1.2.0"
3+
version = "1.2.2"
44
description = "An application to explore/analyze data for atmosphere component for E3SM"
55
authors = [
66
{name = "Kitware Inc."},
@@ -38,9 +38,6 @@ dependencies = [
3838
tauri = [
3939
"pyinstaller",
4040
]
41-
vue2 = [
42-
"trame-grid-layout>=1.0.3",
43-
]
4441
jupyter = [
4542
"jupyter-server-proxy>=4.0.0",
4643
]
@@ -64,11 +61,12 @@ packages = [
6461
]
6562

6663
[project.scripts]
67-
compareview-vue2 = "e3sm_compareview.app:main"
6864
compareview = "e3sm_compareview.app:main"
65+
quickcompare = "e3sm_compareview.app:main"
6966

7067
[project.entry-points."jupyter_serverproxy_servers"]
7168
compareview = "e3sm_compareview.jupyter:setup_compareview"
69+
quickcompare = "e3sm_compareview.jupyter:setup_quickcompare"
7270

7371
[tool.ruff.lint.per-file-ignores]
7472
"e3sm_compareview/pipeline.py" = ["F821"] # Plugin classes loaded dynamically

scripts/setup_tauri.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ python -m PyInstaller --clean --noconfirm \
1919
--collect-all pyproj \
2020
--collect-all netCDF4 \
2121
--collect-all paraview \
22+
--collect-all e3sm_quickview \
2223
--collect-all e3sm_compareview \
2324
--hidden-import pkgutil \
2425
--add-binary="$PVPYTHON_PATH:." \

src-tauri/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22
name = "app"
3-
version = "1.2.0"
4-
description = "CompareView: Visual Analysis for E3SM Atmosphere Data"
3+
version = "1.2.2"
4+
description = "QuickCompare: Visual Analysis for E3SM Atmosphere Data"
55
authors = ["Kitware"]
66
license = ""
77
repository = ""

src-tauri/sidecar/trame-x86_64-unknown-linux-gnu

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
#!/bin/bash
22
basedir=$(cd "$(dirname "$0")/../lib" && pwd)
33

4-
if [ -d "$basedir/compareview" ]; then
4+
if [ -d "$basedir/quickcompare" ]; then
5+
rootdir="$basedir/quickcompare"
6+
elif [ -d "$basedir/compareview" ]; then
57
rootdir="$basedir/compareview"
8+
elif [ -d "$basedir/quick-compare" ]; then
9+
rootdir="$basedir/quick-compare"
610
elif [ -d "$basedir/compare-view" ]; then
711
rootdir="$basedir/compare-view"
812
else
9-
echo "Error: Could not find compareview or compare-view directory in $basedir" >&2
13+
echo "Error: Could not find quickcompare, quick-compare, compareview, or compare-view directory in $basedir" >&2
1014
exit 1
1115
fi
1216

src-tauri/tauri.conf.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"distDir": "./www"
77
},
88
"package": {
9-
"productName": "CompareView",
10-
"version": "1.2.0"
9+
"productName": "QuickCompare",
10+
"version": "1.2.2"
1111
},
1212
"tauri": {
1313
"allowlist": {
@@ -69,7 +69,7 @@
6969
"fullscreen": false,
7070
"height": 600,
7171
"resizable": true,
72-
"title": "CompareView",
72+
"title": "QuickCompare",
7373
"width": 800,
7474
"visible": false,
7575
"additionalBrowserArgs": "--force-device-scale-factor=1"

src/e3sm_compareview/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""CompareView: E3SM CompareView application."""
22

33
# TODO(decouple): Revisit "quickview" naming/usage in Tauri configs after refactor.
4-
__version__ = "1.2.0"
4+
__version__ = "1.2.2"
55
__author__ = "Kitware Inc."
66
__license__ = "Apache-2.0"

src/e3sm_compareview/app.py

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
comparison_signature_for,
1919
label_signature_for,
2020
)
21-
from e3sm_compareview.components import drawers, file_browser, toolbars
21+
from e3sm_compareview.components import doc, drawers, file_browser, toolbars
2222
from e3sm_compareview.pipeline import EAMVisSource
2323
from e3sm_compareview.view_manager import ViewManager
24-
from e3sm_quickview.components import css, dialogs, doc
24+
from e3sm_quickview.components import css, dialogs
2525
from e3sm_quickview import module as qv_module
2626
from e3sm_quickview.utils import cli, compute
2727

@@ -44,7 +44,7 @@ def __init__(self, server=None):
4444
# Initial UI state
4545
self.state.update(
4646
{
47-
"trame__title": "CompareView",
47+
"trame__title": "QuickCompare",
4848
"trame__favicon": ASSETS.icon,
4949
"is_tauri": False,
5050
"animation_play": False,
@@ -111,12 +111,27 @@ async def wait_for_import(**_):
111111

112112
@life_cycle.server_ready
113113
def _tauri_ready(self, **_):
114-
os.write(1, f"tauri-server-port={self.server.port}\n".encode())
114+
jupyter_url_prefix = os.environ.get("JUPYTERHUB_SERVICE_PREFIX")
115+
jupyter_url_api = os.environ.get("JUPYTERHUB_API_URL")
116+
if jupyter_url_prefix:
117+
base_url = "https://jupyter.nersc.gov"
118+
if jupyter_url_api:
119+
base_url = jupyter_url_api[:-8]
120+
121+
os.write(
122+
1,
123+
"\nUse URL below to connect to the application:\n\n => "
124+
f"{base_url}{jupyter_url_prefix}proxy/{self.server.port}"
125+
"/index.html?ui=main&reconnect=auto\n\n".encode(),
126+
)
127+
else:
128+
os.write(1, f"tauri-server-port={self.server.port}\n".encode())
115129

116130
@life_cycle.client_connected
117131
def _tauri_show(self, **_):
118-
os.write(1, "tauri-client-ready\n".encode())
119-
132+
jupyter_url_prefix = os.environ.get("JUPYTERHUB_SERVICE_PREFIX")
133+
if not jupyter_url_prefix:
134+
os.write(1, "tauri-client-ready\n".encode())
120135
# -------------------------------------------------------------------------
121136
# UI definition
122137
# -------------------------------------------------------------------------
@@ -700,7 +715,7 @@ def toggle_toolbar(self, toolbar_name=None):
700715
# -------------------------------------------------------------------------
701716
def main():
702717
app = EAMApp()
703-
app.server.start()
718+
app.server.start(show_connection_info=False, open_browser=False)
704719

705720

706721
if __name__ == "__main__":

0 commit comments

Comments
 (0)