fix(view): fix colorbar range display bug

Author: willdunklin

src/e3sm_compareview/components/view.py

@@ -154,7 +154,7 @@ def create_bottom_bar(config, update_color_preset):
                                 classes="rounded",
                             )
             html.Div(
-                "{{ utils.quickview.formatRange(config.color_range?.[0], config.use_log_scale, config.color_range?.[0], config.color_range?.[1]) }}",
+                "{{ config.color_range_min_label }}",
                 classes="text-caption px-2 text-no-wrap",
             )
             with html.Div(
@@ -191,6 +191,6 @@ def create_bottom_bar(config, update_color_preset):
                             style=("`width:1.5px;flex:1;background:${tick.color};`",),
                         )
             html.Div(
-                "{{ utils.quickview.formatRange(config.color_range?.[1], config.use_log_scale, config.color_range?.[0], config.color_range?.[1]) }}",
+                "{{ config.color_range_max_label }}",
                 classes="text-caption px-2 text-no-wrap",
             )

src/e3sm_compareview/utils/__init__.py

@@ -0,0 +1,4 @@
+from .format import format_color_range_endpoint as format_color_range_endpoint
+from .format import format_color_range_endpoints as format_color_range_endpoints
+
+__all__ = ["format_color_range_endpoint", "format_color_range_endpoints"]

src/e3sm_compareview/utils/format.py

@@ -0,0 +1,41 @@
+import math
+
+
+def format_color_range_endpoint(value, scale="linear", range_min=None, range_max=None):
+    if value is None:
+        return "Auto"
+
+    try:
+        value = float(value)
+    except (TypeError, ValueError):
+        return "Auto"
+
+    if math.isnan(value):
+        return "Auto"
+
+    if scale == "log" and value > 0:
+        return f"10^({math.log10(value):.1f})"
+
+    if scale == "symlog":
+        if value == 0:
+            return "0"
+        range_min = 0 if range_min is None else float(range_min)
+        range_max = 0 if range_max is None else float(range_max)
+        linthresh = max(abs(range_min), abs(range_max)) * 1e-2 or 1.0
+        abs_value = abs(value)
+        if abs_value <= linthresh:
+            return f"{value:.1e}"
+        sign = "-" if value < 0 else ""
+        return f"{sign}10^({math.log10(abs_value):.1f})"
+
+    if value == 0:
+        return "0"
+    return f"{value:.4g}"
+
+
+def format_color_range_endpoints(color_range, scale="linear"):
+    range_min, range_max = color_range
+    return [
+        format_color_range_endpoint(range_min, scale, range_min, range_max),
+        format_color_range_endpoint(range_max, scale, range_min, range_max),
+    ]

src/e3sm_compareview/view_manager.py

@@ -11,6 +11,7 @@
 from vtkmodules.vtkRenderingCore import vtkActor, vtkPolyDataMapper
 
 from e3sm_compareview.components import view as tview
+from e3sm_compareview.utils import format_color_range_endpoints
 from e3sm_quickview.presets import COLOR_BLIND_SAFE
 from e3sm_quickview.utils.color import COLORBAR_CACHE, lut_to_img
 from e3sm_quickview.utils.math import compute_color_ticks, tick_contrast_color
@@ -73,6 +74,8 @@ class ViewConfiguration(dataclass.StateDataModel):
     lut_img: str = dataclass.Sync(str)
     color_ticks: list = dataclass.Sync(list, list)
     effective_color_range: list[float] = dataclass.Sync(tuple[float, float], (0, 1))
+    color_range_min_label: str = dataclass.Sync(str, "0")
+    color_range_max_label: str = dataclass.Sync(str, "1")
 
 
 class VariableView(TrameComponent):
@@ -434,6 +437,12 @@ def update_color_range(self, *_):
 
     def _compute_ticks(self):
         vmin, vmax = self.config.color_range
+        (
+            self.config.color_range_min_label,
+            self.config.color_range_max_label,
+        ) = format_color_range_endpoints(
+            self.config.color_range, self.config.use_log_scale
+        )
         ticks = compute_color_ticks(vmin, vmax, scale=self.config.use_log_scale, n=5)
         if not ticks:
             self.config.color_ticks = []

src/e3sm_compareview/view_manager2.py

@@ -25,6 +25,7 @@
 )
 
 from e3sm_compareview.components import view as tview
+from e3sm_compareview.utils import format_color_range_endpoints
 from e3sm_quickview.presets import COLOR_BLIND_SAFE
 from e3sm_quickview.utils.color import COLORBAR_CACHE, lut_to_img
 from e3sm_quickview.utils.math import compute_color_ticks, tick_contrast_color
@@ -87,6 +88,8 @@ class ViewConfiguration(dataclass.StateDataModel):
     lut_img: str = dataclass.Sync(str)
     color_ticks: list = dataclass.Sync(list, list)
     effective_color_range: list[float] = dataclass.Sync(tuple[float, float], (0, 1))
+    color_range_min_label: str = dataclass.Sync(str, "0")
+    color_range_max_label: str = dataclass.Sync(str, "1")
 
 
 class VariableView(TrameComponent):
@@ -477,6 +480,12 @@ def update_color_range(self, *_):
 
     def _compute_ticks(self):
         vmin, vmax = self.config.color_range
+        (
+            self.config.color_range_min_label,
+            self.config.color_range_max_label,
+        ) = format_color_range_endpoints(
+            self.config.color_range, self.config.use_log_scale
+        )
         ticks = compute_color_ticks(vmin, vmax, scale=self.config.use_log_scale, n=5)
         if not ticks:
             self.config.color_ticks = []