Skip to content

Commit b60639a

Browse files
authored
Merge pull request #86 from tamaynard/fix-cubeaxesstyle
fix(GeometryRepresentation): Allow setting of cubeAxesStyle when cube…
2 parents bf6f64c + e18cd85 commit b60639a

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/core/GeometryRepresentation.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -191,14 +191,17 @@ export default class GeometryRepresentation extends Component {
191191
this.lookupTable.updateRange();
192192
}
193193

194-
if (showCubeAxes && this.cubeAxes == null) {
195-
changed = true;
196-
this.initCubeAxes();
194+
if (showCubeAxes) {
195+
if (this.cubeAxes == null) {
196+
changed = true;
197+
this.initCubeAxes();
198+
}
197199

198200
if (
199201
cubeAxesStyle &&
200202
(!previous || cubeAxesStyle !== previous.cubeAxesStyle)
201203
) {
204+
changed = true;
202205
this.cubeAxes.set(cubeAxesStyle);
203206
}
204207
}

usage/package-lock.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)