Merge pull request #117 from jadh4v/fix-DataArray-setRange

floryst · web-flow · commit d45d66d70e4f · 2023-07-27T09:21:44.000-04:00
Fix setRange call to vtkDataArray for single component arrays
diff --git a/src/core/DataArray.ts b/src/core/DataArray.ts
@@ -110,7 +110,11 @@ export default function DataArray(props: DataArrayProps) {
       const typedArrayClass = TypedArrayLookup[TYPED_ARRAYS[type]];
       array.setData(toTypedArray(values, typedArrayClass), numberOfComponents);
       if (range) {
-        array.setRange(range, numberOfComponents);
+        if (numberOfComponents === 1) {
+          array.setRange(range, 0);
+        } else {
+          array.setRange(range, numberOfComponents);
+        }
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,11 @@ export default function DataArray(props: DataArrayProps) {`
`110`	`110`	`const typedArrayClass = TypedArrayLookup[TYPED_ARRAYS[type]];`
`111`	`111`	`array.setData(toTypedArray(values, typedArrayClass), numberOfComponents);`
`112`	`112`	`if (range) {`
`113`		`- array.setRange(range, numberOfComponents);`
	`113`	`+ if (numberOfComponents === 1) {`
	`114`	`+ array.setRange(range, 0);`
	`115`	`+ } else {`
	`116`	`+ array.setRange(range, numberOfComponents);`
	`117`	`+ }`
`114`	`118`	`}`
`115`	`119`	`}`
`116`	`120`