Skip to content

showOrientationAxis doesn't work anymore #78

Open
@WesleyTheGeolien

Description

@WesleyTheGeolien

It looks like: #59 introduced a bug meaning View components with showOrientationAxis={true} no longer works. here is a codesandbox demo: https://codesandbox.io/s/react-vtk-with-data-template-k86emm?file=/src/App.js

I believe there are 2 approaches:

  • force the user to specify a renderer and renderwindow
  • if renderer and renderwindow are undefined create them as before (probably better?)

Happy to do the PR if you guide upon which solution is preferred

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions