ClientTriggers exit event fails on >=3.11.3

[MattTheCuber]

In v3.11.3, a change was made (commit e8524b4) that broke the ClientTriggers exit event. The event is just not being called anymore.

You can recreate this by running the example here with trame-client<3.11.3 and then again with trame-client>=3.11.3.

[bourdaisj]

the client_exited lifecycle hook might be broken as well. I guess we would need to flush the session before closing it. WDYT @jourdain ?

[jourdain]

I think client_exited still works, but I think we need to give more room for the client to trigger component unmount before closing the connection. We just need to close the connection later... I don't know if we should set a flag somewhere and if the TrameApp (root) is unmounted, then we close the connection. That will allow (maybe) all the other component unmount to complete.

[jourdain]

@bourdaisj are you planning to look into it?

[bourdaisj]

I've think about it - I don't like the flag approach. Ideally I think we should only rely once and only once on window.addEventListener("beforeunload" - in TrameApp.js - elsewhere it would be nice to have a client-side mechanism to listen to lifecycle updates.

In terms of code in TrameClientTriggers.js, we would have:

    // Callback to run AFTER client_exited lifecycle update and BEFORE the session close
    // The session will close after all registered callback completion
    trame.lifecycle.onClientExited(async () => {
      emit("exit");

      // To make sure our event is handled before the session is closed
      await nextTick();
    });

instead of:

  window.addEventListener("beforeunload", () => {
    emit("exit");
  });

wdyt?

[jourdain]

I don't think that will change anything...

[jourdain]

I think we need something like

window.addEventListener("beforeunload", () => {
    trame.client?.getRemote()?.Trame?.lifeCycleUpdate("client_exited");

    setTimeout(() => {
        trame.client?.getConnection()?.getSession()?.close();
    }, 100);
}