Fix wavelet example, widget bugs, docs, and tests#3
Merged
Conversation
- widgets.py: missing f-string prefix on symlog icon expression - module.py: create trame module stub so enable_module works - transforms.py: apply_discrete_symlog early returns 3-tuple -> 4-tuple - trame/widgets/colormaps.py: add docstrings
- Fix scalar_mode 'points' -> 'point' in set_data_array - Use vtkAppendPolyData to merge both pipelines into one mapper - All four colorbars share self.mapper, no sync logic needed - Update module docstring for new architecture
- dataclasses.py: remove ColormapController refs, fix field docs, PRESET_REGISTRY -> COLORBAR_CACHE, update section comments - transforms.py: already committed (ColormapController -> ColormapConfig) - trame/dataclasses/colormaps.py: add module docstring
- Delete test_controller.py, test_state.py (imported removed modules) - Add test_dataclasses.py (defaults, mutations, mapper wiring, presets) - Add test_widgets.py (buttons helper, f-string regression, exports) - Add test_module.py (module.setup no-op) - Update test_smoke.py (trame entry point import tests) - 138 tests passing
patrickoleary
force-pushed
the
fix/wavelet-and-docs
branch
from
2316802 to
19876fd
Compare
jourdain
reviewed
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
mdi-stairsinstead ofmdi-sine-waveenable_moduleworksapply_discrete_symlogearly returns were 3-tuples instead of 4-tuplesArchitecture Changes (wavelet.py)
scalar_mode'points'→'point'inset_data_arrayvtkAppendPolyDataself.mapper, no sync logic neededVertical Colorbar Tick Fix (widgets.py)
flex-direction:columntoflex-direction:rowwriting-mode:vertical-lr)Docstring/Comment Fixes
ColormapControllerreferences, fixed field docs,PRESET_REGISTRY→COLORBAR_CACHE, updated section commentsColormapController→ColormapConfig, fixed return type docsTests
test_controller.py,test_state.py(imported removed modules)test_dataclasses.py,test_widgets.py,test_module.pytest_smoke.pywith real import tests