fix(unregister_vtkobject): fix internal method call

Author: jourdain

src/trame_vtklocal/module/protocol.py

@@ -1,14 +1,15 @@
+import json
 import time
-from functools import wraps
 import zipfile
-import json
+from functools import wraps
 from pathlib import Path
-from wslink import register as export_rpc
-from wslink.websocket import LinkProtocol
+
+from vtkmodules.vtkCommonCore import vtkVersion
 
 # from vtkmodules.vtkCommonCore import vtkLogger
 from vtkmodules.vtkSerializationManager import vtkObjectManager
-from vtkmodules.vtkCommonCore import vtkVersion
+from wslink import register as export_rpc
+from wslink.websocket import LinkProtocol
 
 try:
     import zlib  # noqa
@@ -83,9 +84,9 @@ def register_widget(self, root_obj, dep_obj):
         # print(f"Register widget: {dep_obj.GetClassName()}={dep_id}")
 
     def unregister_widget(self, root_obj, dep_obj):
-        self.vtk_object_manager.UnRegisterObject(dep_obj)
         root_id = self.vtk_object_manager.GetId(root_obj)
         dep_id = self.vtk_object_manager.GetId(dep_obj)
+        self.vtk_object_manager.UnRegisterObject(dep_id)
         if root_id in self._widgets:
             self._widgets[root_id].discard(dep_id)
 

src/trame_vtklocal/widgets/vtklocal.py

@@ -1,15 +1,16 @@
 import asyncio
+import base64
 import io
 import json
-import zipfile
-import base64
 import warnings
+import zipfile
 from pathlib import Path
-from trame_client.widgets.core import AbstractElement
-from trame_vtklocal import module
 
+from trame_client.widgets.core import AbstractElement
 from trame_common.exec.throttle import Throttle
 
+from trame_vtklocal import module
+
 try:
     import zlib  # noqa
 
@@ -235,15 +236,15 @@ def register_widget(self, w):
     def unregister_vtk_object(self, vtk_instance):
         """Unregister external element (i.e. widget) from the scene so it can removed from tracking"""
         if vtk_instance in self.__registered_obj:
-            self.api.unregister(self._render_window, vtk_instance)
+            self.api.unregister_widget(self._render_window, vtk_instance)
             return True
 
         return False
 
     def unregister_all_vtk_objects(self):
         """Unregister all external element (i.e. widget) from the scene"""
         for vtk_instance in self.__registered_obj:
-            self.api.unregister(self._render_window, vtk_instance)
+            self.api.unregister_widget(self._render_window, vtk_instance)
             self.__registered_obj.remove(vtk_instance)
 
     def unregister_widgets(self):