fix(clipclosedsurface): fix various uninitialized variables

The logic was broken at some places. It may improve the behavior of ClipClosedSurface and other
filters

Author: finetjul

Sources/Common/DataModel/IncrementalOctreePointLocator/index.js

@@ -63,16 +63,15 @@ function vtkIncrementalOctreePointLocator(publicAPI, model) {
     return [pntIdx, dist2];
   };
 
-  publicAPI.findClosestPointInSphere = (point, radius2, maskNode, refDist2) => {
+  publicAPI.findClosestPointInSphere = (point, radius2, maskNode, minDist2, refDist2) => {
     let pointIndx = -1;
-    let minDist2 = Number.MAX_VALUE;
 
     const nodesBase = [];
     nodesBase.push(model.octreeRootNode);
 
     let checkNode;
     let childNode;
-    let distToData;
+    let distToData; 
     let tempDist2;
     let tempPntId;
 
@@ -346,7 +345,6 @@ function vtkIncrementalOctreePointLocator(publicAPI, model) {
   publicAPI.isInsertedPointForNonZeroTolerance = (x) => {
     // minDist2 // min distance to ALL existing points
     // elseDst2 // min distance to other nodes (inner boundaries)
-    let dist2Ext; // min distance to an EXTended set of nodes
     let pntIdExt;
 
     // the target leaf node always exists there since the root node of the
@@ -371,12 +369,10 @@ function vtkIncrementalOctreePointLocator(publicAPI, model) {
 
     if (elseDst2 < model.insertTolerance2) {
       // one or multiple closer points might exist in the neighboring nodes
-      // TODO: dist2Ext
-      pntIdExt = publicAPI.findClosestPointInSphereWithTolerance(
+      const [pntIdExt, dist2Ext] = publicAPI.findClosestPointInSphereWithTolerance(
         x,
         model.insertTolerance2,
-        leafContainer,
-        dist2Ext
+        leafContainer
       );
 
       if (dist2Ext < minDist2) {

Sources/Common/DataModel/Triangle/index.js

@@ -483,12 +483,11 @@ function vtkTriangle(publicAPI, model) {
       }
       outObj.evaluation = 1;
     } else {
-      let t;
       if (closestPoint) {
         if (weights[1] < 0.0 && weights[2] < 0.0) {
           dist2Point = vtkMath.distance2BetweenPoints(x, pt3);
-          dist2Line1 = vtkLine.distanceToLine(x, pt1, pt3, t, closestPoint1);
-          dist2Line2 = vtkLine.distanceToLine(x, pt3, pt2, t, closestPoint2);
+          dist2Line1 = vtkLine.distanceToLine(x, pt1, pt3, closestPoint1);
+          dist2Line2 = vtkLine.distanceToLine(x, pt3, pt2, closestPoint2);
           if (dist2Point < dist2Line1) {
             outObj.dist2 = dist2Point;
             closest = pt3;
@@ -505,8 +504,8 @@ function vtkTriangle(publicAPI, model) {
           }
         } else if (weights[2] < 0.0 && weights[0] < 0.0) {
           dist2Point = vtkMath.distance2BetweenPoints(x, pt1);
-          dist2Line1 = vtkLine.distanceToLine(x, pt1, pt3, t, closestPoint1);
-          dist2Line2 = vtkLine.distanceToLine(x, pt1, pt2, t, closestPoint2);
+          dist2Line1 = vtkLine.distanceToLine(x, pt1, pt3, closestPoint1);
+          dist2Line2 = vtkLine.distanceToLine(x, pt1, pt2, closestPoint2);
           if (dist2Point < dist2Line1) {
             outObj.dist2 = dist2Point;
             closest = pt1;
@@ -523,8 +522,8 @@ function vtkTriangle(publicAPI, model) {
           }
         } else if (weights[1] < 0.0 && weights[0] < 0.0) {
           dist2Point = vtkMath.distance2BetweenPoints(x, pt2);
-          dist2Line1 = vtkLine.distanceToLine(x, pt2, pt3, t, closestPoint1);
-          dist2Line2 = vtkLine.distanceToLine(x, pt1, pt2, t, closestPoint2);
+          dist2Line1 = vtkLine.distanceToLine(x, pt2, pt3, closestPoint1);
+          dist2Line2 = vtkLine.distanceToLine(x, pt1, pt2, closestPoint2);
           if (dist2Point < dist2Line1) {
             outObj.dist2 = dist2Point;
             closest = pt2;

Sources/Filters/General/ClipClosedSurface/index.js

@@ -27,9 +27,9 @@ function vtkClipClosedSurface(publicAPI, model) {
   /**
    * Take three colors as doubles, and convert to unsigned char.
    *
-   * @param {Number} color1
-   * @param {Number} color2
-   * @param {Number} color3
+   * @param {Number[3]} color1
+   * @param {Number[3]} color2
+   * @param {Number[3]} color3
    * @param {Number[3][3]} colors
    */
   function createColorValues(color1, color2, color3, colors) {

Sources/Filters/General/ContourTriangulator/helper.js

@@ -1822,8 +1822,8 @@ export function vtkCCSFindCuts(
           points.getPoint(outerPoly[k], q1);
           points.getPoint(innerPoly[j], q2);
 
-          let u;
-          let v;
+          let u = [];
+          let v = [];
           if (
             vtkLine.intersection(p1, p2, q1, q2, u, v) ===
             vtkLine.IntersectionState.YES_INTERSECTION

Sources/Interaction/Widgets/PiecewiseGaussianWidget/index.js

@@ -3,6 +3,7 @@ import * as vtkMath from 'vtk.js/Sources/Common/Core/Math';
 
 import WebworkerPromise from 'webworker-promise';
 
+// eslint-disable-next-line import/no-unresolved, import/default
 import ComputeHistogramWorker from './ComputeHistogram.worker';
 
 /* eslint-disable no-continue */

Sources/Rendering/OpenGL/CellArrayBufferObject/index.js

@@ -2,7 +2,6 @@ import { vec3 } from 'gl-matrix';
 
 import macro from 'vtk.js/Sources/macros';
 import vtkBufferObject from 'vtk.js/Sources/Rendering/OpenGL/BufferObject';
-import vtkCellArray from 'vtk.js/Sources/Common/Core/CellArray';
 import { ObjectType } from 'vtk.js/Sources/Rendering/OpenGL/BufferObject/Constants';
 import { Representation } from 'vtk.js/Sources/Rendering/Core/Property/Constants';
 import {

Sources/Rendering/OpenGL/Texture/supportsNorm16Linear.js

@@ -107,7 +107,7 @@ function supportsNorm16Linear() {
     }
 
     return r === g && g === b && r !== 0;
-  } catch (e) {
+  } catch {
     return false;
   }
 }