test: re-enable four tests skipped during past tooling migrations

Four tests were skipped over the years, each during a test-harness or
build migration rather than for a genuine feature failure. A skipped
test is green in CI, so none produced a signal and all silently
rotted. Re-enable them.

testLabelmapOutlineManyRenderer
  Skipped 2022-03-11 in commit 50ace42 (PR #2308, "Make test
  harnesses the same for release and PRs"); the commit gave no
  reason. While skipped the code rotted: createLabelPipeline called
  backgroundImageData.getDimensionsByReference(), which is not a
  function on vtkImageData. Use getDimensions(). Passes against the
  existing baseline, so no baseline change.

testEdgeVisibility
  Skipped 2021-11-12 in commit 13b9be1 (PR #2161, "Update test
  framework"), flagged in a pixelmatch-threshold-0 audit (PR #2098,
  closed unmerged) as a "bad image test" (issue #2104). The 2017
  baseline predates commit a8873e5 (2021-02-19,
  "feat(vtkopenglpolydatamapper): add support for backface
  property"), which changed the edge draw path from lit
  (ambient = getAmbient(), diffuse = getDiffuse()) to flat
  (ambient = 1.0, diffuse = 0.0): edges now render at the full
  configured edge color, the intended behavior. The render has been
  stable since at least 2021-06 (a steady 1.80% from the 2017
  baseline at 2021-06, 2022, and 2024). Refresh the baseline; the
  tolerance is unchanged at 1% (chromium ~0%, firefox passes).

testAverageIntensityProjection
  Skipped 2021-11-12 in commit 13b9be1 (PR #2161), tracked by
  issue #2102. It did not drift or regress. Before the 2021
  test-framework work the test was effectively a no-op: the old
  compareImages passed its threshold argument (here 1.5) straight to
  pixelmatch, whose threshold range is 0 to 1, so pixelmatch reported
  zero differing pixels for any image and the test passed vacuously.
  The pixelmatch-threshold-0 audit (PR #2098, closed unmerged)
  exposed the real comparison, and the test then "failed" because its
  baseline had never actually been checked.

  The committed baseline is the original 2019 image from aae2f55;
  commit 8a50448 only renamed it OpenGL/ to Core/ (100% rename).
  It is a near-blank volume the real render never matched. Rendering
  against old Sources shows a stable, correct head volume back to
  2021-06 (~1.5% from the corrected baseline, ~0% on current master).

  Replace the baseline with the actual render (chromium ~0%, firefox
  0.01%, within the 1% tolerance) and re-enable the test. Also
  release resources via .finally; gc.releaseResources had been passed
  as an unused 5th argument to compareImages.

testSetTable
  Skipped 2026-05-21 by the Vite/Vitest migration (c0d9887),
  which rewrote test.onlyIfWebGL(...) as it.skip(...) instead of the
  it.skipIf(__VTK_TEST_NO_WEBGL__)(...) form used for every other
  migrated WebGL test, silently disabling a passing test. Restore the
  intended WebGL-conditional skip.

Closes #2102

Author: PaulHax

Sources/Common/Core/LookupTable/test/testSetTable.js

@@ -12,7 +12,7 @@ import vtkPolyData from 'vtk.js/Sources/Common/DataModel/PolyData';
 
 import baseline from './testSetTable.png';
 
-it.skip('Test LookupTable setTable', () => {
+it.skipIf(__VTK_TEST_NO_WEBGL__)('Test LookupTable setTable', () => {
   const gc = testUtils.createGarbageCollector();
   expect('rendering', 'vtkLookupTable TestSetTable').toBeTruthy();
   // testUtils.keepDOM();

Sources/Rendering/Core/Mapper/test/testEdgeVisibility.js

@@ -10,7 +10,7 @@ import vtkMapper from 'vtk.js/Sources/Rendering/Core/Mapper';
 
 import baseline from './testEdgeVisibility.png';
 
-it.skip('Test Edge Visibility', () => {
+it.skipIf(__VTK_TEST_NO_WEBGL__)('Test Edge Visibility', () => {
   const gc = testUtils.createGarbageCollector();
   expect('rendering', 'vtkMapper EdgeVisibility').toBeTruthy();
 
@@ -50,7 +50,7 @@ it.skip('Test Edge Visibility', () => {
       testUtils.compareImages(
         image,
         [baseline],
-        'Rendering/Core/Mapper/testEdgeVisibility.js',
+        'Rendering/Core/Mapper/testEdgeVisibility',
         1
       )
     )

Sources/Rendering/Core/Mapper/test/testEdgeVisibility.png

@@ -14,87 +14,92 @@ import Constants from 'vtk.js/Sources/Rendering/Core/VolumeMapper/Constants';
 
 import baseline from './testAverageIntensityProjection.png';
 
-it.skip('Test Average Intensity Projection Volume Rendering', async () => {
-  const gc = testUtils.createGarbageCollector();
-  expect('rendering', 'vtkVolumeMapper AverageIP').toBeTruthy();
-  // testUtils.keepDOM();
-
-  // Create some control UI
-  const container = document.querySelector('body');
-  const renderWindowContainer = gc.registerDOMElement(
-    document.createElement('div')
-  );
-  container.appendChild(renderWindowContainer);
-
-  // create what we will view
-  const renderWindow = gc.registerResource(vtkRenderWindow.newInstance());
-  const renderer = gc.registerResource(vtkRenderer.newInstance());
-  renderWindow.addRenderer(renderer);
-  renderer.setBackground(0.32, 0.34, 0.43);
-
-  const actor = gc.registerResource(vtkVolume.newInstance());
-
-  const mapper = gc.registerResource(vtkVolumeMapper.newInstance());
-  mapper.setSampleDistance(0.7);
-  mapper.setBlendMode(Constants.BlendMode.AVERAGE_INTENSITY_BLEND);
-
-  actor.setMapper(mapper);
-
-  const reader = vtkHttpDataSetReader.newInstance({ fetchGzip: true });
-
-  // create color and opacity transfer functions
-  const ctfun = vtkColorTransferFunction.newInstance();
-  ctfun.addRGBPoint(-3024, 0, 0, 0);
-  ctfun.addRGBPoint(-637.62, 1, 1, 1);
-  ctfun.addRGBPoint(700, 1, 1, 1);
-  ctfun.addRGBPoint(3071, 1, 1, 1);
-  ctfun.setMappingRange(500, 3000);
-
-  const ofun = vtkPiecewiseFunction.newInstance();
-  ofun.addPoint(-3024, 0);
-  ofun.addPoint(-637.62, 0);
-  ofun.addPoint(700, 0.5);
-  ofun.addPoint(3071, 0.9);
-
-  actor.getProperty().setRGBTransferFunction(0, ctfun);
-  actor.getProperty().setScalarOpacity(0, ofun);
-  actor.getProperty().setScalarOpacityUnitDistance(0, 4.5);
-  actor.getProperty().setInterpolationTypeToFastLinear();
-
-  mapper.setInputConnection(reader.getOutputPort());
-
-  // now create something to view it
-  const glwindow = gc.registerResource(renderWindow.newAPISpecificView());
-  glwindow.setContainer(renderWindowContainer);
-  renderWindow.addView(glwindow);
-  glwindow.setSize(400, 400);
-
-  // Interactor
-  const interactor = vtkRenderWindowInteractor.newInstance();
-  interactor.setStillUpdateRate(0.01);
-  interactor.setView(glwindow);
-  interactor.initialize();
-  interactor.bindEvents(renderWindowContainer);
-
-  await reader.setUrl(`${__BASE_PATH__}/Data/volume/headsq.vti`);
-  await reader.loadData();
-
-  renderer.addVolume(actor);
-  renderer.resetCamera();
-
-  const promise = glwindow.captureNextImage().then((image) =>
-    testUtils.compareImages(
-      image,
-      [baseline],
-      'Rendering/Core/VolumeMapper/testAverageIntensityProjection',
-      {
-        // be stricter here
-        pixelThreshold: 0.01,
-        mismatchTolerance: 1.0,
-      },
-      gc.releaseResources
-    )
-  );
-  renderWindow.render();
-  return promise;
-});
+it.skipIf(__VTK_TEST_NO_WEBGL__)(
+  'Test Average Intensity Projection Volume Rendering',
+  async () => {
+    const gc = testUtils.createGarbageCollector();
+    expect('rendering', 'vtkVolumeMapper AverageIP').toBeTruthy();
+    // testUtils.keepDOM();
+
+    // Create some control UI
+    const container = document.querySelector('body');
+    const renderWindowContainer = gc.registerDOMElement(
+      document.createElement('div')
+    );
+    container.appendChild(renderWindowContainer);
+
+    // create what we will view
+    const renderWindow = gc.registerResource(vtkRenderWindow.newInstance());
+    const renderer = gc.registerResource(vtkRenderer.newInstance());
+    renderWindow.addRenderer(renderer);
+    renderer.setBackground(0.32, 0.34, 0.43);
+
+    const actor = gc.registerResource(vtkVolume.newInstance());
+
+    const mapper = gc.registerResource(vtkVolumeMapper.newInstance());
+    mapper.setSampleDistance(0.7);
+    mapper.setBlendMode(Constants.BlendMode.AVERAGE_INTENSITY_BLEND);
+
+    actor.setMapper(mapper);
+
+    const reader = vtkHttpDataSetReader.newInstance({ fetchGzip: true });
+
+    // create color and opacity transfer functions
+    const ctfun = vtkColorTransferFunction.newInstance();
+    ctfun.addRGBPoint(-3024, 0, 0, 0);
+    ctfun.addRGBPoint(-637.62, 1, 1, 1);
+    ctfun.addRGBPoint(700, 1, 1, 1);
+    ctfun.addRGBPoint(3071, 1, 1, 1);
+    ctfun.setMappingRange(500, 3000);
+
+    const ofun = vtkPiecewiseFunction.newInstance();
+    ofun.addPoint(-3024, 0);
+    ofun.addPoint(-637.62, 0);
+    ofun.addPoint(700, 0.5);
+    ofun.addPoint(3071, 0.9);
+
+    actor.getProperty().setRGBTransferFunction(0, ctfun);
+    actor.getProperty().setScalarOpacity(0, ofun);
+    actor.getProperty().setScalarOpacityUnitDistance(0, 4.5);
+    actor.getProperty().setInterpolationTypeToFastLinear();
+
+    mapper.setInputConnection(reader.getOutputPort());
+
+    // now create something to view it
+    const glwindow = gc.registerResource(renderWindow.newAPISpecificView());
+    glwindow.setContainer(renderWindowContainer);
+    renderWindow.addView(glwindow);
+    glwindow.setSize(400, 400);
+
+    // Interactor
+    const interactor = vtkRenderWindowInteractor.newInstance();
+    interactor.setStillUpdateRate(0.01);
+    interactor.setView(glwindow);
+    interactor.initialize();
+    interactor.bindEvents(renderWindowContainer);
+
+    await reader.setUrl(`${__BASE_PATH__}/Data/volume/headsq.vti`);
+    await reader.loadData();
+
+    renderer.addVolume(actor);
+    renderer.resetCamera();
+
+    const promise = glwindow
+      .captureNextImage()
+      .then((image) =>
+        testUtils.compareImages(
+          image,
+          [baseline],
+          'Rendering/Core/VolumeMapper/testAverageIntensityProjection',
+          {
+            // be stricter here
+            pixelThreshold: 0.01,
+            mismatchTolerance: 1.0,
+          }
+        )
+      )
+      .finally(gc.releaseResources);
+    renderWindow.render();
+    return promise;
+  }
+);