Skip to content

Commit fe78744

Browse files
Kjubikstronkclaude
andcommitted
Label their picks, not yours
createdBy has been stored on every date since the first commit and shown nowhere, so a shared list gave no sense of who put what in it. Only their picks are labelled. You already know what you added, so marking your own would put a line on every card to say nothing — and the card had one line too many before the redesign trimmed it. Asymmetric on purpose: "their pick" is information, "your pick" is noise. Costs no extra reads — it compares against the signed-in uid rather than resolving a name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 270b274 commit fe78744

2 files changed

Lines changed: 17 additions & 2 deletions

File tree

‎src/components/DateCard.tsx‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,15 @@ function DateCard({
6161
const [memoryNote, setMemoryNote] = useState(mine?.note ?? '')
6262

6363
const cancelled = item.status === 'cancelled'
64+
65+
/**
66+
* Whose idea this was.
67+
*
68+
* Only ever shown for theirs. You already know what you added, so labelling
69+
* your own picks would put a line on every card to say nothing — and the
70+
* card had one line too many to begin with.
71+
*/
72+
const theirPick = !!item.createdBy && item.createdBy !== me
6473
/** Flat in a list, raised while you're working on it. */
6574
const asRow = !!flat && mode === 'idle'
6675

@@ -200,6 +209,12 @@ function DateCard({
200209
</span>
201210
)}
202211

212+
{theirPick && (
213+
<span className="legend mt-1 block text-[var(--color-ink)]/60">
214+
their pick
215+
</span>
216+
)}
217+
203218
{item.scheduledFor && (hideDay ? item.time : true) && (
204219
<span
205220
className={

‎src/lib/preview.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export const SAMPLE_DATES: DateIdea[] = [
8686
cancelReason: null,
8787
memories: null,
8888
coupleId: PREVIEW_COUPLE,
89-
createdBy: 'preview',
89+
createdBy: 'them',
9090
createdAt: Date.now(),
9191
},
9292
{
@@ -109,7 +109,7 @@ export const SAMPLE_DATES: DateIdea[] = [
109109
cancelReason: null,
110110
memories: null,
111111
coupleId: PREVIEW_COUPLE,
112-
createdBy: 'preview',
112+
createdBy: 'them',
113113
createdAt: Date.now(),
114114
},
115115
{

0 commit comments

Comments
 (0)