Code detection improvements (#5)

* feat: prefer EAN13 > 8 when multiple

* fix: false positive EAN for longer strings

Author: WezSieTato

content_scripts/pola.js

@@ -43,7 +43,9 @@
         text = text.replace(/<script\b[^<]*(?:(?!<\/script>)<[^<]*)*<\/script>/gi, ' ');
         text = text.replace(/<style\b[^<]*(?:(?!<\/style>)<[^<]*)*<\/style>/gi, ' ');
         text = text.replace(/<[^>]+>/gi, ' ');
-        result = text.match(/\d{13}|\d{8}/g);
+        // Granice (?<!\d)/(?!\d) wykluczają fragmenty dłuższych ciągów cyfr,
+        // np. 13-cyfrowy prefiks 14-cyfrowego kodu wewnętrznego sklepu.
+        result = text.match(/(?<!\d)(?:\d{13}|\d{8})(?!\d)/g);
         let gtin13 = document.querySelectorAll('meta[itemprop="gtin13"][content]');
         let gtin8 = document.querySelectorAll('meta[itemprop="gtin8"][content]');
         let flix = document.querySelectorAll('script[data-flix-ean]');
@@ -63,6 +65,14 @@
     if (result !== null) {
         result = result.filter((v, i, a) => a.indexOf(v) === i);
         result = result.filter(validateEAN);
+        // Krótkie kody wewnętrzne sklepów bywają błędnie łapane jako EAN-8;
+        // jeśli obok nich jest dokładnie jeden EAN-13, uznaj go za właściwy kod.
+        if (result.length > 1) {
+            let ean13 = result.filter((v) => v.length === 13);
+            if (ean13.length === 1) {
+                result = ean13;
+            }
+        }
     }
     if (result !== null && result.length === 1) {
         chrome.runtime.sendMessage({

lib/validateEAN.js

@@ -2,7 +2,7 @@
  * Validates an EAN-8 or EAN-13 barcode using the check digit algorithm.
  */
 function validateEAN(elem) {
-    if (isNaN(elem)) {
+    if (isNaN(elem) || (elem.length !== 8 && elem.length !== 13)) {
         return false;
     }
     let sum = 0;

package.json

@@ -5,7 +5,7 @@
   "private": true,
   "scripts": {
     "test": "jest",
-    "test:integration": "xvfb-run npx playwright test"
+    "test:integration": "npx playwright test"
   },
   "devDependencies": {
     "@playwright/test": "^1.61.1",

test-e2e/ean-detection.spec.js

@@ -177,8 +177,6 @@ test.describe('EAN detection on real product pages', () => {
 
             if (eanMessage) {
                 expect(eanMessage.result).toBe(ean);
-            } else if (multipleMessage) {
-                expect(multipleMessage.result).toContain(ean);
             } else {
                 throw new Error(
                     `Content script nie znalazł EAN ${ean} na stronie ${store}. ` +

test/validateEAN.test.js

@@ -46,6 +46,18 @@ describe('validateEAN', () => {
             expect(validateEAN('12345')).toBe(false);
         });
 
+        test('14-digit internal code (00461455550000)', () => {
+            expect(validateEAN('00461455550000')).toBe(false);
+        });
+
+        test('valid EAN-13 with extra digit appended (59003977457800)', () => {
+            expect(validateEAN('59003977457800')).toBe(false);
+        });
+
+        test('12 digits (590039774578)', () => {
+            expect(validateEAN('590039774578')).toBe(false);
+        });
+
         test('non-numeric string', () => {
             expect(validateEAN('abcdefghijklm')).toBe(false);
         });