fix: false positive EAN for longer strings

Author: WezSieTato

content_scripts/pola.js

@@ -43,7 +43,9 @@
         text = text.replace(/<script\b[^<]*(?:(?!<\/script>)<[^<]*)*<\/script>/gi, ' ');
         text = text.replace(/<style\b[^<]*(?:(?!<\/style>)<[^<]*)*<\/style>/gi, ' ');
         text = text.replace(/<[^>]+>/gi, ' ');
-        result = text.match(/\d{13}|\d{8}/g);
+        // Granice (?<!\d)/(?!\d) wykluczają fragmenty dłuższych ciągów cyfr,
+        // np. 13-cyfrowy prefiks 14-cyfrowego kodu wewnętrznego sklepu.
+        result = text.match(/(?<!\d)(?:\d{13}|\d{8})(?!\d)/g);
         let gtin13 = document.querySelectorAll('meta[itemprop="gtin13"][content]');
         let gtin8 = document.querySelectorAll('meta[itemprop="gtin8"][content]');
         let flix = document.querySelectorAll('script[data-flix-ean]');

lib/validateEAN.js

@@ -2,7 +2,7 @@
  * Validates an EAN-8 or EAN-13 barcode using the check digit algorithm.
  */
 function validateEAN(elem) {
-    if (isNaN(elem)) {
+    if (isNaN(elem) || (elem.length !== 8 && elem.length !== 13)) {
         return false;
     }
     let sum = 0;

test/validateEAN.test.js

@@ -46,6 +46,18 @@ describe('validateEAN', () => {
             expect(validateEAN('12345')).toBe(false);
         });
 
+        test('14-digit internal code (00461455550000)', () => {
+            expect(validateEAN('00461455550000')).toBe(false);
+        });
+
+        test('valid EAN-13 with extra digit appended (59003977457800)', () => {
+            expect(validateEAN('59003977457800')).toBe(false);
+        });
+
+        test('12 digits (590039774578)', () => {
+            expect(validateEAN('590039774578')).toBe(false);
+        });
+
         test('non-numeric string', () => {
             expect(validateEAN('abcdefghijklm')).toBe(false);
         });