Skip to content

Commit ac96b71

Browse files
authored
Merge pull request #402 from garak/fix-test-deprecations
fix test deprecations
2 parents a96dc1e + f07e7d5 commit ac96b71

File tree

1 file changed

+19
-24
lines changed

1 file changed

+19
-24
lines changed

.github/workflows/build.yaml

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66

77
jobs:
88
check:
9-
runs-on: ubuntu-22.04
9+
runs-on: ubuntu-24.04
1010
steps:
1111
- name: Checkout
1212
uses: actions/checkout@v4
@@ -15,63 +15,56 @@ jobs:
1515
- name: Validate composer.json
1616
run: composer validate --strict --no-check-lock
1717
cs-fixer:
18-
runs-on: ubuntu-22.04
18+
runs-on: ubuntu-24.04
1919
name: PHP-CS-Fixer
2020
steps:
2121
- name: Checkout
2222
uses: actions/checkout@v4
2323
- name: Fix CS
2424
uses: docker://oskarstark/php-cs-fixer-ga
2525
twig-cs-fixer:
26-
runs-on: ubuntu-22.04
26+
runs-on: ubuntu-24.04
2727
name: Twig-CS-Fixer
2828
steps:
2929
- name: Checkout
3030
uses: actions/checkout@v4
3131
- name: Require the vendor
32-
run: composer require --dev --no-update vincentlanglet/twig-cs-fixer ^2.12
32+
run: composer require --dev --no-update vincentlanglet/twig-cs-fixer ^3.5
3333
- name: Update
3434
run: composer update --no-interaction --no-progress
3535
- name: Run
3636
run: vendor/bin/twig-cs-fixer lint src/Knp/Menu/Resources/views
3737
tests:
38-
runs-on: ubuntu-22.04
38+
runs-on: ubuntu-24.04
3939
strategy:
4040
fail-fast: false
4141
matrix:
4242
include:
4343
- description: 'No Symfony specified'
4444
php: '8.1'
45-
env:
46-
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
45+
max_deprecations: 1
4746
- description: 'No Symfony specified'
4847
php: '8.2'
49-
env:
50-
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
48+
max_deprecations: 1
5149
- description: 'No Symfony specified'
5250
php: '8.3'
53-
env:
54-
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
51+
max_deprecations: 1
5552
- description: 'No Symfony specified'
5653
php: '8.4'
57-
env:
58-
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
54+
max_deprecations: 1
5955
- description: 'Lowest deps'
6056
php: '8.1'
6157
composer_option: '--prefer-lowest'
62-
env:
63-
SYMFONY_DEPRECATIONS_HELPER: max[self]=0
64-
- description: 'Symfony 5.4'
58+
max_deprecations: 0
59+
- description: 'Symfony 6'
6560
php: '8.1'
66-
symfony: 5.4.*
67-
env:
68-
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
69-
- description: 'Dev deps'
70-
php: '8.3'
61+
symfony: 6.4.*
62+
max_deprecations: 1
63+
- description: 'Symfony 7'
64+
php: '8.4'
7165
dev: true
7266
symfony: 7.2.*
73-
env:
74-
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
67+
max_deprecations: 1
7568
name: PHP ${{ matrix.php }} tests (${{ matrix.description }})
7669
steps:
7770
- name: Checkout
@@ -92,8 +85,10 @@ jobs:
9285
if: matrix.dev
9386
- run: composer update --no-interaction --no-progress --ansi ${{ matrix.composer_option }}
9487
- run: vendor/bin/phpunit
88+
env:
89+
SYMFONY_DEPRECATIONS_HELPER: max[self]=${{matrix.max_deprecations}}
9590
phpstan:
96-
runs-on: ubuntu-22.04
91+
runs-on: ubuntu-24.04
9792
name: PHPStan
9893
steps:
9994
- name: Checkout

0 commit comments

Comments
 (0)