enforce Symfony coding standards

Author: garak

.gitignore

@@ -1,2 +1,3 @@
+.*.cache
 composer.lock
 vendor/*

.php_cs

@@ -0,0 +1,17 @@
+<?php
+// see https://github.com/FriendsOfPHP/PHP-CS-Fixer
+
+$finder = PhpCsFixer\Finder::create()
+    ->exclude('vendor')
+    ->in([__DIR__])
+;
+
+return PhpCsFixer\Config::create()
+    ->setRiskyAllowed(true)
+    ->setRules([
+        '@Symfony' => true,
+        '@Symfony:risky' => true,
+        'array_syntax' => ['syntax' => 'short'],
+    ])
+    ->setFinder($finder)
+;

src/DependencyInjection/Compiler/AddExtensionsPass.php

@@ -23,7 +23,7 @@ public function process(ContainerBuilder $container)
         }
 
         $taggedServiceIds = $container->findTaggedServiceIds('knp_menu.factory_extension');
-        if (0 === count($taggedServiceIds)) {
+        if (0 === \count($taggedServiceIds)) {
             return;
         }
 

src/DependencyInjection/Compiler/AddProvidersPass.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Knp\Bundle\MenuBundle\DependencyInjection\Compiler;
 
 use Symfony\Component\DependencyInjection\Argument\IteratorArgument;
@@ -26,7 +27,7 @@ public function process(ContainerBuilder $container)
             $providers[] = new Reference($id);
         }
 
-        if (1 === count($providers)) {
+        if (1 === \count($providers)) {
             // Use an alias instead of wrapping it in the ChainProvider for performances
             // when using only one (the default case as the bundle defines one provider)
             $container->setAlias('knp_menu.menu_provider', (string) reset($providers));

src/DependencyInjection/Compiler/AddRenderersPass.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Knp\Bundle\MenuBundle\DependencyInjection\Compiler;
 
 use Knp\Menu\Renderer\PsrProvider;

src/DependencyInjection/Compiler/AddVotersPass.php

@@ -55,7 +55,7 @@ public function process(ContainerBuilder $container)
         }
 
         krsort($voters);
-        $sortedVoters = call_user_func_array('array_merge', $voters);
+        $sortedVoters = \call_user_func_array('array_merge', $voters);
 
         if (class_exists(IteratorArgument::class)) {
             $definition->replaceArgument(0, new IteratorArgument($sortedVoters));

src/DependencyInjection/Compiler/MenuPass.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Knp\Bundle\MenuBundle\DependencyInjection\Compiler;
 
 use Symfony\Component\DependencyInjection\ContainerBuilder;

src/DependencyInjection/Configuration.php

@@ -6,7 +6,7 @@
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 
 /**
- * This class contains the configuration information for the bundle
+ * This class contains the configuration information for the bundle.
  *
  * @author Christophe Coevoet <[email protected]>
  */

src/DependencyInjection/KnpMenuExtension.php

@@ -62,7 +62,7 @@ public function getNamespace()
      */
     public function getXsdValidationBasePath()
     {
-        return __DIR__ . '/../Resources/config/schema';
+        return __DIR__.'/../Resources/config/schema';
     }
 
     public function prepend(ContainerBuilder $container)
@@ -71,9 +71,8 @@ public function prepend(ContainerBuilder $container)
             return;
         }
 
-
         $refl = new \ReflectionClass(ItemInterface::class);
-        $path = dirname($refl->getFileName()).'/Resources/views';
+        $path = \dirname($refl->getFileName()).'/Resources/views';
 
         $container->prependExtensionConfig('twig', ['paths' => [$path]]);
     }

src/Provider/BuilderAliasProvider.php

@@ -10,7 +10,7 @@
 use Symfony\Component\HttpKernel\KernelInterface;
 
 /**
- * A menu provider that allows for an AcmeBundle:Builder:mainMenu shortcut syntax
+ * A menu provider that allows for an AcmeBundle:Builder:mainMenu shortcut syntax.
  *
  * @author Ryan Weaver <[email protected]>
  */
@@ -32,7 +32,7 @@ public function __construct(KernelInterface $kernel, ContainerInterface $contain
     }
 
     /**
-     * Looks for a menu with the bundle:class:method format
+     * Looks for a menu with the bundle:class:method format.
      *
      * For example, AcmeBundle:Builder:mainMenu would create and instantiate
      * an Acme\DemoBundle\Menu\Builder class and call the mainMenu() method
@@ -42,6 +42,7 @@ public function __construct(KernelInterface $kernel, ContainerInterface $contain
      * @param array  $options
      *
      * @return \Knp\Menu\ItemInterface
+     *
      * @throws \InvalidArgumentException
      */
     public function get($name, array $options = [])
@@ -71,15 +72,15 @@ public function get($name, array $options = [])
      * @param string $name    The alias name of the menu
      * @param array  $options
      *
-     * @return Boolean
+     * @return bool
      */
     public function has($name, array $options = [])
     {
         return 2 == substr_count($name, ':');
     }
 
     /**
-     * Creates and returns the builder that lives in the given bundle
+     * Creates and returns the builder that lives in the given bundle.
      *
      * The convention is to look in the Menu namespace of the bundle for
      * this class, to instantiate it with no arguments, and to inject the
@@ -104,7 +105,7 @@ protected function getBuilder($bundleName, $className)
             $allBundles = $this->kernel->getBundle($bundleName, false);
 
             // In Symfony 4, bundle inheritance is gone, so there is no way to get an array anymore.
-            if (!is_array($allBundles)) {
+            if (!\is_array($allBundles)) {
                 $allBundles = [$allBundles];
             }
 
@@ -120,7 +121,7 @@ protected function getBuilder($bundleName, $className)
             }
 
             if (null === $class) {
-                if (1 === count($logs)) {
+                if (1 === \count($logs)) {
                     throw new \InvalidArgumentException($logs[0]);
                 }