Merge pull request #304 from garak/remove-php73

Remove support for php 7.3

Author: garak

.github/workflows/build.yaml

@@ -29,21 +29,14 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php:
-                    - '7.3'
-                    - '7.4'
-                    - '8.0'
-                    - '8.1'
                 include:
                     - description: 'Lowest'
-                      composer_option: '--prefer-lowest'
-                    - description: '7.4'
                       php: '7.4'
+                      composer_option: '--prefer-lowest'
                     - description: '8.0'
                       php: '8.0'
                     - description: '8.1'
                       php: '8.1'
-                      composer_option: ''
         name: PHP ${{ matrix.php }} tests (${{ matrix.description }})
         steps:
             - name: Checkout

composer.json

@@ -22,7 +22,7 @@
         }
     ],
     "require": {
-        "php": "^7.3 || ^8.0",
+        "php": "^7.4 || ^8.0",
         "symfony/event-dispatcher-contracts": "^2.0 || ^3.0",
         "symfony/http-foundation": "^4.4 || ^5.4 || ^6.0"
     },

src/Knp/Component/Pager/Event/AfterEvent.php

@@ -10,7 +10,7 @@
  */
 final class AfterEvent extends Event
 {
-    private $pagination;
+    private PaginationInterface $pagination;
 
     public function __construct(PaginationInterface $paginationView)
     {

src/Knp/Component/Pager/Event/BeforeEvent.php

@@ -11,9 +11,9 @@
  */
 final class BeforeEvent extends Event
 {
-    private $eventDispatcher;
+    private EventDispatcherInterface $eventDispatcher;
 
-    private $request;
+    private ?Request $request;
 
     public function __construct(EventDispatcherInterface $eventDispatcher, ?Request $request)
     {

src/Knp/Component/Pager/Event/ItemsEvent.php

@@ -18,10 +18,8 @@ final class ItemsEvent extends Event
 
     /**
      * List of options
-     *
-     * @var array
      */
-    public $options;
+    public array $options;
 
     /**
      * Items result
@@ -32,14 +30,12 @@ final class ItemsEvent extends Event
 
     /**
      * Count result
-     *
-     * @var integer
      */
-    public $count;
+    public int $count;
 
-    private $offset;
-    private $limit;
-    private $customPaginationParams = [];
+    private int $offset;
+    private int $limit;
+    private array $customPaginationParams = [];
 
     public function __construct(int $offset, int $limit)
     {

src/Knp/Component/Pager/Event/PaginationEvent.php

@@ -19,12 +19,10 @@ final class PaginationEvent extends Event
 
     /**
      * List of options
-     *
-     * @var array
      */
-    public $options;
+    public array $options;
 
-    private $pagination;
+    private PaginationInterface $pagination;
 
     public function setPagination(PaginationInterface $pagination): void
     {

src/Knp/Component/Pager/Event/Subscriber/Filtration/Doctrine/ORM/QuerySubscriber.php

@@ -12,10 +12,7 @@
 
 class QuerySubscriber implements EventSubscriberInterface
 {
-    /**
-     * @var Request
-     */
-    private $request;
+    private Request $request;
 
     public function __construct(?Request $request)
     {

src/Knp/Component/Pager/Event/Subscriber/Filtration/FiltrationSubscriber.php

@@ -9,9 +9,8 @@ class FiltrationSubscriber implements EventSubscriberInterface
 {
     /**
      * Lazy-load state tracker
-     * @var bool
      */
-    private $isLoaded = false;
+    private bool $isLoaded = false;
 
     public function before(BeforeEvent $event): void
     {

src/Knp/Component/Pager/Event/Subscriber/Filtration/PropelQuerySubscriber.php

@@ -9,10 +9,7 @@
 
 class PropelQuerySubscriber implements EventSubscriberInterface
 {
-    /**
-     * @var Request
-     */
-    private $request;
+    private Request $request;
 
     public function __construct(?Request $request)
     {

src/Knp/Component/Pager/Event/Subscriber/Paginate/Callback/CallbackPagination.php

@@ -19,10 +19,6 @@ class CallbackPagination
      */
     private $items;
 
-    /**
-     * @param callable $count
-     * @param callable $items
-     */
     public function __construct(callable $count, callable $items)
     {
         $this->count = $count;
@@ -36,6 +32,6 @@ public function getPaginationCount(): int
 
     public function getPaginationItems(int $offset, int $limit): array
     {
-        return call_user_func_array($this->items, [$offset, $limit]);
+        return call_user_func($this->items, $offset, $limit);
     }
 }