Skip to content

Commit 857cad1

Browse files
authored
Merge pull request #478 from KnpLabs/v2-unstable-change-interfaces
fix: Change interfaces function names
2 parents f0c3a85 + efc2878 commit 857cad1

File tree

5 files changed

+18
-13
lines changed

5 files changed

+18
-13
lines changed

src/Core/Bridge/FromFileToStringToPdf.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,16 @@
77
use KnpLabs\Snappy\Core\FileToPdf;
88
use KnpLabs\Snappy\Core\StringToPdf;
99
use Psr\Http\Message\StreamInterface;
10-
use SplFileInfo;
1110

1211
final class FromFileToStringToPdf implements FileToPdf
1312
{
1413
public function __construct(private StringToPdf $stringToPdf)
1514
{
1615
}
1716

18-
public function generate(SplFileInfo $file, ArrayAccess|array $options = []): StreamInterface
17+
public function generateFromFile(\SplFileInfo $file, \ArrayAccess|array $options = []): StreamInterface
1918
{
20-
return $this->stringToPdf->generate(
19+
return $this->stringToPdf->generateFromString(
2120
file_get_contents($file->getPathname()),
2221
$options,
2322
);

src/Core/Bridge/FromStringToFileToPdf.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,23 @@
77
use KnpLabs\Snappy\Core\FileToPdf;
88
use KnpLabs\Snappy\Core\StringToPdf;
99
use Psr\Http\Message\StreamInterface;
10-
use SplFileInfo;
1110

1211
final class FromStringToFileToPdf implements StringToPdf
1312
{
1413
public function __construct(private FileToPdf $fileToPdf)
1514
{
1615
}
1716

18-
public function generate(string $html, ArrayAccess|array $options = []): StreamInterface
17+
public function generateFromString(string $html, \ArrayAccess|array $options = []): StreamInterface
1918
{
2019
$path = tempnam(sys_get_temp_dir(), 'snappy_');
2120

2221
try {
2322
file_put_contents($path, $html);
2423

25-
$file = new SplFileInfo($path);
24+
$file = new \SplFileInfo($path);
2625

27-
$stream = $this->fileToPdf->generate($file, $options);
26+
$stream = $this->fileToPdf->generateFromFile($file, $options);
2827
} finally {
2928
unlink($path);
3029
}

src/Core/FileToPdf.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@
22

33
namespace KnpLabs\Snappy\Core;
44

5-
use ArrayAccess;
65
use Psr\Http\Message\StreamInterface;
7-
use SplFileInfo;
86

97
interface FileToPdf
108
{
11-
public function generate(SplFileInfo $file, ArrayAccess|array $options = []): StreamInterface;
9+
public function generateFromFile(\SplFileInfo $file, \ArrayAccess|array $options = []): StreamInterface;
1210
}

src/Core/StringToPdf.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@
22

33
namespace KnpLabs\Snappy\Core;
44

5-
use ArrayAccess;
65
use Psr\Http\Message\StreamInterface;
7-
use SplFileInfo;
86

97
interface StringToPdf
108
{
11-
public function generate(string $html, ArrayAccess|array $options = []): StreamInterface;
9+
public function generateFromString(string $html, \ArrayAccess|array $options = []): StreamInterface;
1210
}

src/Core/UriToPdf.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<?php
2+
3+
namespace KnpLabs\Snappy\Core;
4+
5+
use Psr\Http\Message\StreamInterface;
6+
use Psr\Http\Message\UriInterface;
7+
8+
interface UriToPdf
9+
{
10+
public function generateFromUri(UriInterface $url, \ArrayAccess|array $options = []): StreamInterface;
11+
}

0 commit comments

Comments
 (0)