fix: Universal Electronics Inc XHS2-UE: fix battery voltage curve (#12609)

Author: klinquist

src/devices/universal_electronics_inc.ts

@@ -32,7 +32,7 @@ export const definitions: DefinitionWithExtend[] = [
         description: "Magnetic door & window contact sensor",
         fromZigbee: [fz.ias_contact_alarm_1, fz.temperature, fz.battery],
         toZigbee: [],
-        meta: {battery: {voltageToPercentage: "3V_2100"}},
+        meta: {battery: {voltageToPercentage: {min: 2500, max: 2800}}},
         configure: async (device, coordinatorEndpoint) => {
             const endpoint = device.getEndpoint(1);
             await reporting.bind(endpoint, coordinatorEndpoint, ["msTemperatureMeasurement", "genPowerCfg"]);

test/fromZigbee.test.ts

@@ -1,6 +1,6 @@
 import {describe, expect, it} from "vitest";
 import {definitions as develcoDefinitions} from "../src/devices/develco";
-import {fromZigbee} from "../src/index";
+import {findByDevice, fromZigbee} from "../src/index";
 import {mockDevice} from "./utils";
 
 describe("converters/fromZigbee", () => {
@@ -221,6 +221,37 @@ describe("converters/fromZigbee", () => {
         });
     });
 
+    it("XHS2-UE uses voltage curve instead of stale reported battery percentage", async () => {
+        const definition = await findByDevice(mockDevice({modelID: "URC4460BC0-X-R", endpoints: []}));
+
+        const payload = fromZigbee.battery.convert(
+            definition,
+            {
+                data: {
+                    batteryVoltage: 28,
+                    batteryPercentageRemaining: 54,
+                },
+                endpoint: null,
+                device: null,
+                meta: null,
+                groupID: null,
+                type: "attributeReport",
+                cluster: "genPowerCfg",
+                linkquality: 0,
+            },
+            null,
+            {},
+            {
+                meta: {},
+            }.meta,
+        );
+
+        expect(payload).toStrictEqual({
+            battery: 100,
+            voltage: 2800,
+        });
+    });
+
     describe("command_step_color_temperature", () => {
         const makeMsg = (stepmode: number, stepsize: number, transtime?: number) => ({
             data: {stepmode, stepsize, ...(transtime !== undefined ? {transtime} : {})},