Handle Shelly cover config params responses

Author: MaxRink

src/devices/shelly.ts

@@ -897,11 +897,12 @@ const shellyModernExtend = {
                 if (!ep) return;
                 try {
                     const response = await rpcRequest(ep, "Cover.GetConfig", {id: 0});
-                    if (!response?.result) return;
-                    assertObject<KeyValue>(response.result);
-                    if (!response.result.slat) return;
-                    assertObject<KeyValue>(response.result.slat);
-                    const enabled = response.result.slat.enable;
+                    const result = response?.result ?? response?.params ?? response;
+                    if (!result) return;
+                    assertObject<KeyValue>(result);
+                    if (!result.slat) return;
+                    assertObject<KeyValue>(result.slat);
+                    const enabled = result.slat.enable;
                     if (typeof enabled === "boolean" && device.meta.cover_tilt_enabled !== enabled) {
                         device.meta.cover_tilt_enabled = enabled;
                         device.save();

test/shelly.test.ts

@@ -93,6 +93,43 @@ describe("Shelly 2PM Gen4 cover mode", () => {
         );
     });
 
+    it("persists Shelly slat control from Cover.GetConfig params during configure", async () => {
+        const response = JSON.stringify({id: 1, params: {id: 0, slat: {enable: true}}});
+        const read = vi
+            .fn()
+            .mockResolvedValueOnce({rxCtl: 0})
+            .mockResolvedValueOnce({rxCtl: 0})
+            .mockResolvedValueOnce({rxCtl: response.length})
+            .mockResolvedValueOnce({data: response});
+        const device = mockShelly2PMCoverWithInputs(read);
+        const save = vi.spyOn(device, "save").mockImplementation(() => {});
+        const definition = await findByDevice(device);
+
+        await definition.configure?.(device, mockShelly2PMCover().getEndpoint(1), definition);
+
+        expect(device.meta.cover_tilt_enabled).toBe(true);
+        expect(save).toHaveBeenCalledTimes(1);
+    });
+
+    it("overwrites stale persisted slat control from Cover.GetConfig during configure", async () => {
+        const response = JSON.stringify({id: 1, result: {id: 0, slat: {enable: false}}});
+        const read = vi
+            .fn()
+            .mockResolvedValueOnce({rxCtl: 0})
+            .mockResolvedValueOnce({rxCtl: 0})
+            .mockResolvedValueOnce({rxCtl: response.length})
+            .mockResolvedValueOnce({data: response});
+        const device = mockShelly2PMCoverWithInputs(read);
+        device.meta.cover_tilt_enabled = true;
+        const save = vi.spyOn(device, "save").mockImplementation(() => {});
+        const definition = await findByDevice(device);
+
+        await definition.configure?.(device, mockShelly2PMCover().getEndpoint(1), definition);
+
+        expect(device.meta.cover_tilt_enabled).toBe(false);
+        expect(save).toHaveBeenCalledTimes(1);
+    });
+
     it("leaves persisted slat control unchanged when Cover.GetConfig has no boolean slat flag", async () => {
         const response = JSON.stringify({id: 1, result: {id: 0}});
         const read = vi