Parameterize internalTemperature reporting via temperatureReporting option

Author: adamawolf

src/devices/inovelli.ts

@@ -19,6 +19,7 @@ export const definitions: DefinitionWithExtend[] = [
             inovelli.m.parameters({
                 attrs: [{attributes: inovelli.VZM30_ATTRIBUTES, clusterName: inovelli.CLUSTER_NAME}],
                 model: inovelli.Model.VZM30,
+                temperatureReporting: {min: 1800, max: 3600, change: 5},
             }),
             inovelli.m.addCustomCluster(),
             m.identify(),
@@ -45,6 +46,7 @@ export const definitions: DefinitionWithExtend[] = [
             inovelli.m.parameters({
                 attrs: [{attributes: inovelli.VZM31_ATTRIBUTES, clusterName: inovelli.CLUSTER_NAME}],
                 model: inovelli.Model.VZM31,
+                temperatureReporting: {min: 1800, max: 3600, change: 5},
             }),
             inovelli.m.addCustomCluster(),
             m.identify(),

src/lib/inovelli.ts

@@ -618,10 +618,12 @@ const inovelliExtend = {
         attrs,
         model,
         splitValuesByEndpoint = false,
+        temperatureReporting,
     }: {
         attrs: Array<{attributes: {[s: string]: Attribute}; clusterName: typeof INOVELLI_CLUSTER_NAME | typeof INOVELLI_MMWAVE_CLUSTER_NAME}>;
         model: Model;
         splitValuesByEndpoint?: boolean;
+        temperatureReporting?: {min: number; max: number; change: number};
     }): ModernExtend => {
         const fromZigbee: NonNullable<ModernExtend["fromZigbee"]> = [];
         const toZigbee: Tz.Converter[] = [];
@@ -654,11 +656,18 @@ const inovelliExtend = {
                 const endpoint = device.getEndpoint(1);
                 await reporting.bind(endpoint, coordinatorEndpoint, [INOVELLI_CLUSTER_NAME]);
 
-                await endpoint
-                    .configureReporting(INOVELLI_CLUSTER_NAME, [
-                        {attribute: 32, minimumReportInterval: 1800, maximumReportInterval: 3600, reportableChange: 5},
-                    ])
-                    .catch((e) => logger.warning(`Failed to configure internalTemperature reporting: ${e.message}`, "zhc:inovelli"));
+                if (temperatureReporting) {
+                    await endpoint
+                        .configureReporting(INOVELLI_CLUSTER_NAME, [
+                            {
+                                attribute: 32,
+                                minimumReportInterval: temperatureReporting.min,
+                                maximumReportInterval: temperatureReporting.max,
+                                reportableChange: temperatureReporting.change,
+                            },
+                        ])
+                        .catch((e) => logger.warning(`Failed to configure internalTemperature reporting: ${e.message}`, "zhc:inovelli"));
+                }
 
                 let endpoint2: Zh.Endpoint | undefined;
                 if (splitValuesByEndpoint) {

test/inovelli.test.ts

@@ -2693,7 +2693,6 @@ describe("Inovelli VZM32-SN definition integration", () => {
             configureReporting: {
                 1: [
                     {cluster: "genOnOff", items: [{attribute: "onOff", min: 0, max: 3600, change: 0}]},
-                    {cluster: "manuSpecificInovelli", items: [{attribute: 32, min: 1800, max: 3600, change: 5}]},
                     {
                         cluster: "haElectricalMeasurement",
                         items: [
@@ -2919,10 +2918,7 @@ describe("Inovelli VZM35-SN definition integration", () => {
             writeCount: {1: 0, 2: 0},
             // fan() extend also configures onOff reporting on EP1; no other reporting clusters for VZM35-SN.
             configureReporting: {
-                1: [
-                    {cluster: "genOnOff", items: [{attribute: "onOff", min: 0, max: 3600, change: 0}]},
-                    {cluster: "manuSpecificInovelli", items: [{attribute: 32, min: 1800, max: 3600, change: 5}]},
-                ],
+                1: [{cluster: "genOnOff", items: [{attribute: "onOff", min: 0, max: 3600, change: 0}]}],
                 2: [],
             },
         });
@@ -3042,10 +3038,7 @@ describe("Inovelli VZM36 definition integration", () => {
             writeCount: {1: 0, 2: 0},
             // light() configures onOff reporting on EP1; fan() configures onOff reporting on EP2.
             configureReporting: {
-                1: [
-                    {cluster: "genOnOff", items: [{attribute: "onOff", min: 0, max: 3600, change: 0}]},
-                    {cluster: "manuSpecificInovelli", items: [{attribute: 32, min: 1800, max: 3600, change: 5}]},
-                ],
+                1: [{cluster: "genOnOff", items: [{attribute: "onOff", min: 0, max: 3600, change: 0}]}],
                 2: [{cluster: "genOnOff", items: [{attribute: "onOff", min: 0, max: 3600, change: 0}]}],
             },
         });